Fix to bug #438 http://bugs.skysql.com/show_bug.cgi?id=438

Fixed some compiler warnings, added header includes, return values etc.

server/core/Makefile

@@ -41,7 +41,7 @@ UTILSPATH := $(ROOT_PATH)/utils
 
 CC=cc
 
-CFLAGS=-c -I/usr/include -I../include -I../inih \
+CFLAGS=-c -I/usr/include -I../include -I../modules/include -I../inih \
 	$(MYSQL_HEADERS) \
 	-I$(LOGPATH) -I$(UTILSPATH) \
 	-Wall -g
@@ -59,7 +59,7 @@ SRCS= atomic.c buffer.c spinlock.c gateway.c \
 	monitor.c adminusers.c secrets.c
 
 HDRS= ../include/atomic.h ../include/buffer.h ../include/dcb.h \
-	../include/gw.h ../include/mysql_protocol.h \
+	../include/gw.h ../modules/include/mysql_client_server_protocol.h \
 	../include/session.h ../include/spinlock.h ../include/thread.h \
 	../include/modules.h ../include/poll.h ../include/config.h \
 	../include/users.h ../include/hashtable.h ../include/gwbitmask.h \

server/core/dbusers.c

@@ -42,6 +42,7 @@
 #include <skygw_utils.h>
 #include <log_manager.h>
 #include <secrets.h>
+#include <mysql_client_server_protocol.h>
 
 #define USERS_QUERY_NO_ROOT " AND user NOT IN ('root')"
 #define LOAD_MYSQL_USERS_QUERY "SELECT user, host, password, concat(user,host,password) AS userdata FROM mysql.user WHERE user IS NOT NULL AND user <> ''"

server/core/dcb.c

@@ -68,6 +68,7 @@
 #include <atomic.h>
 #include <skygw_utils.h>
 #include <log_manager.h>
+#include <hashtable.h>
 
 extern int lm_enabled_logfiles_bitmask;
 

server/core/poll.c

@@ -27,6 +27,7 @@
 #include <gwbitmask.h>
 #include <skygw_utils.h>
 #include <log_manager.h>
+#include <gw.h>
 
 extern int lm_enabled_logfiles_bitmask;
 

server/core/secrets.c

@@ -21,6 +21,7 @@
 #include <skygw_utils.h>
 #include <log_manager.h>
 #include <ctype.h>
+#include <mysql_client_server_protocol.h>
 
 extern int lm_enabled_logfiles_bitmask;
 /**

server/core/service.c

@@ -702,7 +702,7 @@ SERVICE	*ptr;
  * @param dcb		DCB to print data to
  * @param service	The service to print
  */
-dprintService(DCB *dcb, SERVICE *service)
+void dprintService(DCB *dcb, SERVICE *service)
 {
 SERVER	*server = service->databases;