hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix GCC7 warnings in binlogrouter

Browse Source 
GCC7 reported possible destination buffer overflow in binlogrouter.
This commit is contained in:
Markus Mäkelä
2017-10-05 14:51:16 +03:00
parent c6ed779dcf
commit 75d298693c
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/modules/routing/binlogrouter/blr_slave.c
View File

@ -1183,7 +1183,7 @@ blr_slave_send_slave_status(ROUTER_INSTANCE *router,
bool all_slaves) bool all_slaves)
{ {
GWBUF *pkt; GWBUF *pkt;
char column[251] = ""; char column[2048] = "";
uint8_t *ptr; uint8_t *ptr;
int len, actual_len, col_len, seqno, i; int len, actual_len, col_len, seqno, i;
char *dyn_column = NULL; char *dyn_column = NULL;
@ -7428,10 +7428,9 @@ static bool blr_handle_set_stmt(ROUTER_INSTANCE *router,
/* Parse the non empty GTID value */ /* Parse the non empty GTID value */
if (heading[0] && !blr_parse_gtid(heading, &gtid_elms)) if (heading[0] && !blr_parse_gtid(heading, &gtid_elms))
{ {
static const char *err_fmt = "Invalid format for GTID ('%s')" const char err_fmt[] = "Invalid format for GTID ('%s')"
" set request; use 'X-Y-Z'"; " set request; use 'X-Y-Z'";
char err_msg[sizeof(err_fmt) + GTID_MAX_LEN + 1]; char err_msg[sizeof(err_fmt) + GTID_MAX_LEN + 1];
sprintf(err_msg, err_fmt, heading); sprintf(err_msg, err_fmt, heading);
MXS_ERROR("%s", err_msg); MXS_ERROR("%s", err_msg);