Fix to prevent double free of dcb->data/session->data. If authentication fails, call free(dcb->data) only when DCB in question is *not* cloned.

This commit is contained in:
VilhoRaatikka
2014-12-30 12:28:36 +02:00
parent b0c152b55c
commit 77bd279a01
2 changed files with 6 additions and 3 deletions

View File

@ -85,7 +85,7 @@ session_alloc(SERVICE *service, DCB *client_dcb)
"session object due error %d, %s.",
errno,
strerror(errno))));
if (client_dcb->data)
if (client_dcb->data && !DCB_IS_CLONE(client_dcb))
{
free(client_dcb->data);
client_dcb->data = NULL;

View File

@ -721,7 +721,10 @@ int gw_read_client_event(
/**
* Release MYSQL_session since it is not used anymore.
*/
if (!DCB_IS_CLONE(dcb))
{
free(dcb->data);
}
dcb->data = NULL;
dcb_close(dcb);