hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary result processing in readwritesplit

Browse Source 
The result processing code did unnecessary work to confirm that the result
buffers are contiguous. The code also assumed that multiple packets can be
routed at the same time when in fact only one contiguous result packet is
returned at a time.

By assuming that the buffers are contiguous and contain only one packet,
most of the copying and buffer manipulation can be avoided.
This commit is contained in:
Markus Mäkelä
2017-10-05 16:03:00 +03:00
committed by Johan Wikman
parent 8085ee15be
commit 7840c86b7f
3 changed files with 49 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/modules/routing/readwritesplit/rwsplitsession.hh
View File

@ -52,15 +52,15 @@ public:
bool execute_session_command();
bool write(GWBUF* buffer, response_type type = EXPECT_RESPONSE);
void set_modutil_state(const modutil_state& state);
modutil_state get_modutil_state() const;
bool is_large_packet() const;
void set_large_packet(bool value);
private:
reply_state_t m_reply_state;
BackendHandleMap m_ps_handles; /**< Internal ID to backend PS handle mapping */
modutil_state m_modutil_state; /**< Used to store the state of the EOF packet
* calculation for result sets when the result
* contains very large rows */
bool m_large_packet; /**< Used to store the state of the EOF packet
*calculation for result sets when the result
* contains very large rows */
};
typedef std::tr1::shared_ptr<RWBackend> SRWBackend;