hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Print stacktrace in one message

Browse Source 
By printing the stacktrace in one log message, it prevents it from
interleaving with other messages. This happens on busy systems and makes
crash analysis harder.
This commit is contained in:
Markus Mäkelä
2019-10-02 10:44:57 +03:00
parent 9c62aafa93
commit 7f7b052f0e
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
server/core/gateway.cc
View File

@ -411,22 +411,13 @@ static void sigfatal_handler(int i)
MXS_CONFIG* cnf = config_get_global_options();
fprintf(stderr,
"Fatal: MaxScale " MAXSCALE_VERSION " received fatal signal %d. "
"Attempting backtrace.\n",
i);
fprintf(stderr,
"Fatal: MaxScale %s received fatal signal %d. "
"Commit ID: %s System name: %s Release string: %s\n\n",
maxscale_commit,
cnf->sysname,
cnf->release_string);
MAXSCALE_VERSION, i, maxscale_commit, cnf->sysname, cnf->release_string);
MXS_ALERT("Fatal: MaxScale " MAXSCALE_VERSION " received fatal signal %d. "
"Attempting backtrace.",
i);
MXS_ALERT("Commit ID: %s System name: %s Release string: %s",
maxscale_commit,
cnf->sysname,
cnf->release_string);
MXS_ALERT("Fatal: MaxScale %s received fatal signal %d. "
"Commit ID: %s System name: %s Release string: %s",
MAXSCALE_VERSION, i, maxscale_commit, cnf->sysname, cnf->release_string);
if (DCB* dcb = dcb_get_current())
{
@ -437,12 +428,19 @@ static void sigfatal_handler(int i)
}
}
thread_local char msg[4096] = "";
msg[0] = '\0';
auto cb = [](const char* symbol, const char* cmd) {
MXS_ALERT(" %s: %s", symbol, cmd);
char buf[512];
snprintf(buf, sizeof(buf), " %s: %s\n", symbol, cmd);
strcat(msg, buf);
};
mxb::dump_stacktrace(cb);
MXS_ALERT("\n%s", msg);
/* re-raise signal to enforce core dump */
fprintf(stderr, "\n\nWriting core dump\n");
raise(i);