hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1354: Add user authorization to maxadmin

Browse Source 
All commands that modify the internal state of MaxScale now require admin
level authorization.
This commit is contained in:
Markus Mäkelä
2017-08-16 14:29:58 +03:00
parent 9f81f0775f
commit 828649ba99
5 changed files with 66 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/modules/protocol/maxscaled/maxscaled.c
View File

@ -241,7 +241,12 @@ static int maxscaled_read_event(DCB* dcb)
{
case MAXSCALED_STATE_LOGIN:
{
maxscaled->username = strndup((char*)GWBUF_DATA(head), GWBUF_LENGTH(head));
size_t len = GWBUF_LENGTH(head);
char user[len + 1];
memcpy(user, GWBUF_DATA(head), len);
user[len] = '\0';
maxscaled->username = MXS_STRDUP_A(user);
dcb->user = MXS_STRDUP_A(user);
maxscaled->state = MAXSCALED_STATE_PASSWD;
dcb_printf(dcb, MAXADMIN_AUTH_PASSWORD_PROMPT);
gwbuf_free(head);