From 8351bf8451aab95e75aa7e1af3a859b68c585b42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=A4kel=C3=A4?= Date: Thu, 9 Aug 2018 18:16:16 +0300 Subject: [PATCH] Add missing value initialization The query classifier cache statistics returned an uninitialized pointer. --- server/core/query_classifier.cc | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/server/core/query_classifier.cc b/server/core/query_classifier.cc index 2bad9321a..7804c91d1 100644 --- a/server/core/query_classifier.cc +++ b/server/core/query_classifier.cc @@ -1238,23 +1238,15 @@ bool qc_get_cache_stats(QC_CACHE_STATS* pStats) json_t* qc_get_cache_stats_as_json() { - json_t* pStats; + QC_CACHE_STATS stats = {}; + qc_get_cache_stats(&stats); - QC_CACHE_STATS stats; - - if (qc_get_cache_stats(&stats)) - { - pStats = json_object(); - - if (pStats) - { - json_object_set_new(pStats, "size", json_integer(stats.size)); - json_object_set_new(pStats, "inserts", json_integer(stats.inserts)); - json_object_set_new(pStats, "hits", json_integer(stats.hits)); - json_object_set_new(pStats, "misses", json_integer(stats.misses)); - json_object_set_new(pStats, "evictions", json_integer(stats.evictions)); - } - } + json_t* pStats = json_object(); + json_object_set_new(pStats, "size", json_integer(stats.size)); + json_object_set_new(pStats, "inserts", json_integer(stats.inserts)); + json_object_set_new(pStats, "hits", json_integer(stats.hits)); + json_object_set_new(pStats, "misses", json_integer(stats.misses)); + json_object_set_new(pStats, "evictions", json_integer(stats.evictions)); return pStats; }