hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to Coverity issue 72726

Browse Source
This commit is contained in:
VilhoRaatikka
2014-11-05 17:27:37 +02:00
parent e7b6ec644c
commit 86cd6ec0e9
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
utils/skygw_utils.cc
View File

@ -1491,7 +1491,7 @@ skygw_mes_rc_t skygw_message_send(
if (err != 0) { if (err != 0) {
fprintf(stderr, fprintf(stderr,
"* Locking pthread mutex failed, " "* Locking pthread mutex failed, "
"due error %d, %s\n", "due to error %d, %s\n",
err, err,
strerror(errno)); strerror(errno));
goto return_mes_rc; goto return_mes_rc;
@ -1499,25 +1499,28 @@ skygw_mes_rc_t skygw_message_send(
mes->mes_sent = true; mes->mes_sent = true;
err = pthread_cond_signal(&(mes->mes_cond)); err = pthread_cond_signal(&(mes->mes_cond));
if (err != 0) { if (err == 0)
{
rc = MES_RC_SUCCESS;
}
else
{
fprintf(stderr, fprintf(stderr,
"* Signaling pthread cond var failed, " "* Signaling pthread cond var failed, "
"due error %d, %s\n", "due to error %d, %s\n",
err, err,
strerror(errno)); strerror(errno));
goto return_mes_rc;
} }
err = pthread_mutex_unlock(&(mes->mes_mutex)); err = pthread_mutex_unlock(&(mes->mes_mutex));
if (err != 0) { if (err != 0)
{
fprintf(stderr, fprintf(stderr,
"* Unlocking pthread mutex failed, " "* Unlocking pthread mutex failed, "
"due error %d, %s\n", "due to error %d, %s\n",
err, err,
strerror(errno)); strerror(errno));
goto return_mes_rc;
} }
rc = MES_RC_SUCCESS;
return_mes_rc: return_mes_rc:
return rc; return rc;