hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1740 Hintfilter leaks memory

Browse Source 
Single spot where an existing hint ptr was overwritten. Removed gwbuf_add_hint()
because it was  adding hints at the opposite end compared to functions in hint.h.
Added hint_splice() to replace.
This commit is contained in:
Niclas Antti
2018-05-30 09:45:17 +03:00
parent 8917458505
commit 89296ed4e4
6 changed files with 32 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/modules/filter/hintfilter/hintfilter.c
View File

@ -208,8 +208,11 @@ routeQuery(MXS_FILTER *instance, MXS_FILTER_SESSION *session, GWBUF *queue)
{
my_session->request = NULL;
my_session->query_len = 0;
HINT *hint = hint_parser(my_session, queue);
queue->hint = hint;
HINT *new_hint = hint_parser(my_session, queue);
if (new_hint)
{
queue->hint = hint_splice(queue->hint, new_hint);
}
}
/* Now process the request */