From 8a0805d26464b94af0cc9bf2c8addc55d11ad2de Mon Sep 17 00:00:00 2001 From: Johan Wikman Date: Tue, 16 Oct 2018 20:20:29 +0300 Subject: [PATCH] MXS-2090 Drop requirement that GTID based replication is used Drop the requirement that GTID based replication is used for the BinLog Galera "failover" mechanism. There is no reason for that restriction; it works just as well with file+position based replication. --- server/modules/routing/binlogrouter/blr_slave.cc | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/server/modules/routing/binlogrouter/blr_slave.cc b/server/modules/routing/binlogrouter/blr_slave.cc index 3e15e4655..f0fa49940 100644 --- a/server/modules/routing/binlogrouter/blr_slave.cc +++ b/server/modules/routing/binlogrouter/blr_slave.cc @@ -4579,22 +4579,6 @@ int blr_handle_change_master(ROUTER_INSTANCE* router, return -1; } - if (index != 0) - { - // Index 0 refers to the default configuration. - string use_gtid = router->configs[0].use_mariadb10_gtid; - - if (use_gtid.empty() || (strcasecmp(use_gtid.c_str(), "slave_pos") != 0)) - { - static const char MESSAGE[] = - "Secondary masters can only be used in conjunction with GTID based replication. " - "Specify MASTER_USE_GTID=Slave_pos for the default master connection."; - mxb_assert(sizeof(MESSAGE) <= BINLOG_ERROR_MSG_LEN); - strcpy(error, MESSAGE); - return -1; - } - } - std::vector cmd_string(command, command + strlen(command) + 1); // Include the NULL /* Parse SQL command and populate the change_master struct */