hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable disable_sescmd_history by default

Browse Source 
The combination of the default values of `disable_sescmd_history=false`
and `max_slave_connections=100%` does not make sense as it is not possible
to find a replacement slave in case an active one fails.
This commit is contained in:
Markus Mäkelä
2017-01-27 05:21:30 +02:00
parent 3b716bc707
commit 8a1a4c91e4
3 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Documentation/Release-Notes/MaxScale-2.1.0-Release-Notes.md
View File

@ -22,6 +22,13 @@ Please see the
[Configuration Guide](../Getting-Started/Configuration-Guide.md#configuration)
for details.
### Readwritesplit `disable_sescmd_history` option
The default value for `disable_sescmd_history` is now true. This new default
value will prevent the excessive memory use of long-lived connections. In
addition to this, it was not optimal to enable this option while the default
value for `max_slave_connections` was 100%, effectively making it useless.
### Module configurations
MaxScale 2.1 introduces a new directory for module configurations. This new

13
Documentation/Routers/ReadWriteSplit.md
View File

@ -110,7 +110,18 @@ When a limitation is set, it effectively creates a cap on the session's memory c
### `disable_sescmd_history`
**`disable_sescmd_history`** disables the session command history. This way no history is stored and if a slave server fails, the router will not try to replace the failed slave. Disabling session command history will allow connection pooling without causing a constant growth in the memory consumption. The session command history is enabled by default.
This option disables the session command history. This way no history is stored
and if a slave server fails, the router will not try to replace the failed
slave. Disabling session command history will allow long-lived connections
without causing a constant growth in the memory consumption.
This option is only intended to be enabled if the value of
`max_slave_connections` is lowered below the default value. This will allow a
failed slave to be replaced with a standby slave server.
In versions 2.0 and older, the session command history is enabled by
default. Starting with version 2.1, the session command history is disabled by
default.
```
# Disable the session command history

2
server/modules/routing/readwritesplit/readwritesplit.c
View File

@ -191,7 +191,7 @@ MXS_MODULE *MXS_CREATE_MODULE()
{"max_slave_replication_lag", MXS_MODULE_PARAM_INT, "-1"},
{"max_slave_connections", MXS_MODULE_PARAM_STRING, MAX_SLAVE_COUNT},
{"retry_failed_reads", MXS_MODULE_PARAM_BOOL, "true"},
{"disable_sescmd_history", MXS_MODULE_PARAM_BOOL, "false"},
{"disable_sescmd_history", MXS_MODULE_PARAM_BOOL, "true"},
{"max_sescmd_history", MXS_MODULE_PARAM_COUNT, "0"},
{"strict_multi_stmt", MXS_MODULE_PARAM_BOOL, "true"},
{"master_accept_reads", MXS_MODULE_PARAM_BOOL, "false"},