add tests

maxscale-system-test/fwf_syntax.cpp

@@ -0,0 +1,85 @@
+/**
+ * Firewall filter syntax error test
+ *
+ * Generate various syntax errors and check if they are detected.
+ * With every rule file in this test, MaxScale should not start and the error
+ * log should contain a message about a syntax error.
+ */
+
+
+#include <iostream>
+#include <unistd.h>
+#include "testconnections.h"
+#include "fw_copy_rules.h"
+
+const char *temp_rules = "rules_tmp.txt";
+
+const char *users_ok[] =
+{
+    "users %@% match any rules testrule",
+    NULL
+};
+
+const char *rules_failure[] =
+{
+    "rule testrule deny nothing",
+    "rule testrule deny regex",
+    "rule testrule deny columns",
+    "rule testrule deny limit_queries",
+    "rule testrule deny no-where-clause",
+    "rule testrule deny wildcard wildcard",
+    "rule testrule deny wildcard rule testrule deny no_where_clause",
+    "rule testrule allow anything",
+    "rule testrule block",
+    "rule deny wildcard",
+    "testrule deny wildcard",
+    "rule testrule deny wildcard on_queries select | not_select",
+    "rule testrule deny wildcard on_queries select|not_select",
+    "rule testrule deny wildcard on_queries select |",
+    "rule testrule deny wildcard on_queries select|",
+    "rule ᐫᐬᐭᐮᐯᐰᐱ deny wildcard on_queries select|",
+    NULL
+};
+
+void truncate_maxscale_logs(TestConnections *test)
+{
+    test->ssh_maxscale(true, "truncate -s 0 /var/log/maxscale/*");
+}
+
+void add_rule(const char *rule)
+{
+    FILE *file = fopen(temp_rules, "a");
+    fprintf(file, "%s\n", rule);
+    fclose(file);
+}
+
+int main(int argc, char** argv)
+{
+    TestConnections::skip_maxscale_start(true);
+    TestConnections *test = new TestConnections(argc, argv);
+    test->stop_timeout();
+    test->stop_maxscale();
+
+    for (int i = 0; rules_failure[i]; i++)
+    {
+        /** Create rule file with syntax error */
+        truncate(temp_rules, 0);
+        add_rule(rules_failure[i]);
+        add_rule(users_ok[0]);
+        copy_rules(test, (char*)temp_rules, (char*)test_dir);
+
+        test->tprintf("Testing rule: %s\n", rules_failure[i]);
+        test->start_maxscale();
+        sleep(3);
+
+        /** Check that MaxScale did not start and that the log contains
+         * a message about the syntax error. */
+        test->check_maxscale_processes(0);
+        test->check_log_err("syntax error", true);
+        truncate_maxscale_logs(test);
+    }
+
+    int rval = test->global_result;
+    delete test;
+    return rval;
+}