hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1549: Prevent optimistic transaction with no slaves

Browse Source 
If the router session does not have an already open slave connection,
optimistic transactions are not attempted.
This commit is contained in:
Markus Mäkelä 2018-06-25 02:01:25 +03:00
parent 0911c664b1
commit 8cf22dbb56
No known key found for this signature in database
GPG Key ID: 72D48FCE664F7B19
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
server/modules/routing/readwritesplit/rwsplit_route_stmt.cc
View File

@ -151,13 +151,27 @@ void replace_binary_ps_id(GWBUF* buffer, uint32_t id)
}
bool RWSplitSession::have_connected_slaves() const
{
for (const auto& b: m_backends)
{
if (b->is_slave() && b->in_use())
{
return true;
}
}
return false;
}
bool RWSplitSession::should_try_trx_on_slave(route_target_t route_target) const
{
return m_config.optimistic_trx && // Optimistic transactions are enabled
!is_locked_to_master() && // Not locked to master
!m_is_replay_active && // Not replaying a transaction
m_otrx_state == OTRX_INACTIVE && // Not yet in optimistic mode
TARGET_IS_MASTER(route_target); // The target type is master
return m_config.optimistic_trx && // Optimistic transactions are enabled
!is_locked_to_master() && // Not locked to master
!m_is_replay_active && // Not replaying a transaction
m_otrx_state == OTRX_INACTIVE && // Not yet in optimistic mode
TARGET_IS_MASTER(route_target) && // The target type is master
have_connected_slaves(); // At least one connected slave
}
bool RWSplitSession::track_optimistic_trx(GWBUF** buffer)

3
server/modules/routing/readwritesplit/rwsplitsession.hh
View File

@ -204,6 +204,9 @@ private:
void handle_trx_replay();
// Do we have at least one open slave connection
bool have_connected_slaves() const;
/**
* Start the replaying of the latest transaction
*