hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Perform query classifier initialization implicitly

Browse Source 
The setting up and the initialization of the query classifier has
now been separated. The gateway explicitly sets up the query
classifier (i.e. chooses which one to use and what arguments to
provide), but the actual initialization is performed as part of
the general module initialization.
This commit is contained in:
Johan Wikman
2017-01-05 19:24:58 +02:00
parent 530c0e9617
commit 8fc5bdc2f1
13 changed files with 116 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
include/maxscale/query_classifier.h
View File

@ -128,10 +128,11 @@ typedef struct qc_field_info
typedef struct query_classifier
{
bool (*qc_setup)(const char* args);
bool (*qc_init)(void);
void (*qc_end)(void);
bool (*qc_thread_init)(void);
int (*qc_process_init)(void);
void (*qc_process_end)(void);
int (*qc_thread_init)(void);
void (*qc_thread_end)(void);
qc_parse_result_t (*qc_parse)(GWBUF* stmt);
@ -152,10 +153,12 @@ typedef struct query_classifier
} QUERY_CLASSIFIER;
/**
* Loads and initializes the default query classifier.
* Loads and sets up the default query classifier.
*
* This must be called once during the execution of a process. The query
* classifier functions can only be used if this function returns true.
* classifier functions can only be used if this function first and thereafter
* the @c qc_process_init return true.
*
* MaxScale calls this function, so plugins should not do that.
*
* @param plugin_name The name of the plugin from which the query classifier
@ -167,18 +170,32 @@ typedef struct query_classifier
*
* @see qc_end qc_thread_init
*/
bool qc_init(const char* plugin_name, const char* plugin_args);
bool qc_setup(const char* plugin_name, const char* plugin_args);
/**
* Finalizes and unloads the query classifier.
* Intializes the query classifier.
*
* This function should be called once, provided @c qc_setup returned true,
* before the query classifier functionality is used.
*
* MaxScale calls this functions, so plugins should not do that.
*
* @return True, if the process wide initialization could be performed.
*
* @see qc_process_end qc_thread_init
*/
bool qc_process_init(void);
/**
* Finalizes the query classifier.
*
* A successful call of qc_init() should before program exit be followed
* by a call to this function. MaxScale calls this function, so plugins
* should not do that.
*
* @see qc_init qc_thread_end
* @see qc_process_init qc_thread_end
*/
void qc_end(void);
void qc_process_end(void);
/**
* Loads a particular query classifier.
@ -206,10 +223,11 @@ QUERY_CLASSIFIER* qc_load(const char* plugin_name);
void qc_unload(QUERY_CLASSIFIER* classifier);
/**
* Performs thread initialization needed by the query classifier.
* Should be called in every thread, except the one where qc_init()
* was called. MaxScale calls this function, so plugins should not
* do that.
* Performs thread initialization needed by the query classifier. Should
* be called in every thread, except the one where qc_process_init()
* was called.
*
* MaxScale calls this function, so plugins should not do that.
*
* @return True if the initialization succeeded, false otherwise.
*
@ -220,8 +238,9 @@ bool qc_thread_init(void);
/**
* Performs thread finalization needed by the query classifier.
* A successful call to qc_thread_init() should at some point be followed
* by a call to this function. MaxScale calls this function, so plugins
* should not do that.
* by a call to this function.
*
* MaxScale calls this function, so plugins should not do that.
*
* @see qc_thread_init
*/