hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

It only makes sense to flush/rotate the error log.

Browse Source 
The other log files are not used.
This commit is contained in:
Johan Wikman
2015-11-03 14:23:31 +02:00
parent 9ba6ad81b0
commit 9050fce3d4
1 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
log_manager/log_manager.cc
View File

@ -1571,18 +1571,17 @@ int skygw_log_flush(logfile_id_t id)
{ {
int err = -1; int err = -1;
if (id == LOGFILE_ERROR)
{
if (logmanager_register(false)) if (logmanager_register(false))
{ {
CHK_LOGMANAGER(lm); CHK_LOGMANAGER(lm);
if (logmanager_is_valid_id(id))
{
logfile_t *lf = logmanager_get_logfile(lm, id); logfile_t *lf = logmanager_get_logfile(lm, id);
CHK_LOGFILE(lf); CHK_LOGFILE(lf);
logfile_flush(lf); logfile_flush(lf);
err = 0; err = 0;
}
logmanager_unregister(); logmanager_unregister();
} }
@ -1590,6 +1589,12 @@ int skygw_log_flush(logfile_id_t id)
{ {
ss_dfprintf(stderr, "Can't register to logmanager, flushing failed.\n"); ss_dfprintf(stderr, "Can't register to logmanager, flushing failed.\n");
} }
}
else
{
// We'll pretend everything went ok.
err = 0;
}
return err; return err;
} }
@ -1602,12 +1607,12 @@ int skygw_log_rotate(logfile_id_t id)
{ {
int err = -1; int err = -1;
if (id == LOGFILE_ERROR)
{
if (logmanager_register(false)) if (logmanager_register(false))
{ {
CHK_LOGMANAGER(lm); CHK_LOGMANAGER(lm);
if (logmanager_is_valid_id(id))
{
logfile_t *lf = logmanager_get_logfile(lm, id); logfile_t *lf = logmanager_get_logfile(lm, id);
CHK_LOGFILE(lf); CHK_LOGFILE(lf);
@ -1615,7 +1620,6 @@ int skygw_log_rotate(logfile_id_t id)
logfile_rotate(lf); logfile_rotate(lf);
err = 0; err = 0;
}
logmanager_unregister(); logmanager_unregister();
} }
@ -1623,6 +1627,12 @@ int skygw_log_rotate(logfile_id_t id)
{ {
ss_dfprintf(stderr, "Can't register to logmanager, rotating failed.\n"); ss_dfprintf(stderr, "Can't register to logmanager, rotating failed.\n");
} }
}
else
{
// We'll pretend everything went ok.
err = 0;
}
return err; return err;
} }