From 91dd2d9fb835449628f6ddc95091e4d0582fe8ba Mon Sep 17 00:00:00 2001 From: Johan Wikman Date: Thu, 22 Dec 2016 16:30:00 +0200 Subject: [PATCH] Cache: Plug a leak In case the stale item must be refreshed, the stale value must be freed as it will not be sent to the client. --- server/modules/filter/cache/cachefiltersession.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/modules/filter/cache/cachefiltersession.cc b/server/modules/filter/cache/cachefiltersession.cc index 47a79bf82..df78f6de4 100644 --- a/server/modules/filter/cache/cachefiltersession.cc +++ b/server/modules/filter/cache/cachefiltersession.cc @@ -163,6 +163,10 @@ int CacheFilterSession::routeQuery(GWBUF* pPacket) { MXS_NOTICE("Cache data is stale, fetching fresh from server."); } + + // As we don't use the response it must be freed. + gwbuf_free(pResponse); + m_refreshing = true; fetch_from_server = true; }