From 9a6e3a9a86dcd4cf81c80b18fe120bbeea400567 Mon Sep 17 00:00:00 2001 From: Markus Makela Date: Thu, 20 Aug 2015 09:34:52 +0300 Subject: [PATCH] Fix to Coverity defect. --- server/modules/routing/schemarouter/schemarouter.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/modules/routing/schemarouter/schemarouter.c b/server/modules/routing/schemarouter/schemarouter.c index fa82fedef..d0c6ad59c 100644 --- a/server/modules/routing/schemarouter/schemarouter.c +++ b/server/modules/routing/schemarouter/schemarouter.c @@ -4518,7 +4518,12 @@ int process_show_shards(ROUTER_CLIENT_SES* rses) sl.iter = iter; sl.rses = rses; - sl.rset = resultset_create(shard_list_cb,&sl); + if((sl.rset = resultset_create(shard_list_cb,&sl)) == NULL) + { + skygw_log_write(LE,"[%s] Error: Failed to create resultset.",__FUNCTION__); + return -1; + } + resultset_add_column(sl.rset,"Database",MYSQL_DATABASE_MAXLEN,COL_TYPE_VARCHAR); resultset_add_column(sl.rset,"Server",MYSQL_DATABASE_MAXLEN,COL_TYPE_VARCHAR); resultset_stream_mysql(sl.rset,rses->rses_client_dcb);