hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed false warnings about readwritesplit parameter types

Browse Source 
The warning was expecting the wrong return value and mistakenly interpreted that
the setting of the parameter failed.
This commit is contained in:
Markus Makela
2016-03-02 08:38:59 +02:00
parent bb1e36e2a5
commit 9b2748f50c
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/core/config.c
View File

@ -2345,10 +2345,8 @@ int create_new_service(CONFIG_CONTEXT *obj)
if ((param = config_get_param(obj->parameters, "use_sql_variables_in"))) if ((param = config_get_param(obj->parameters, "use_sql_variables_in")))
{ {
if (service_set_param_value(obj->element, param, param->value, if (!service_set_param_value(obj->element, param, param->value,
COUNT_NONE, SQLVAR_TARGET_TYPE)) COUNT_NONE, SQLVAR_TARGET_TYPE))
{
if (param)
{ {
MXS_WARNING("Invalid value type for parameter \'%s.%s = %s\'\n\tExpected " MXS_WARNING("Invalid value type for parameter \'%s.%s = %s\'\n\tExpected "
"type is [master|all] for use sql variables in.", "type is [master|all] for use sql variables in.",
@ -2356,7 +2354,6 @@ int create_new_service(CONFIG_CONTEXT *obj)
} }
} }
} }
}
return error_count; return error_count;
} }