hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2002 Make Worker excecution mode explicit

Browse Source 
This is the first step in some cleanup of the Worker interface.
The execution mode must now be explicitly specified, but that is
just a temporary step. Further down the road, _posting_ will
*always* mean via the message loop while _executing_ will optionally
and by default mean direct execution if the calling thread is that
of the worker.
This commit is contained in:
Johan Wikman
2018-08-09 10:58:28 +03:00
parent b9ec3f5130
commit 9cfd451a1d
8 changed files with 56 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/maxscale/worker.hh
View File

@ -730,7 +730,12 @@ public:
* MyResult& result = task.result();
* @endcode
*/
bool post(Task* pTask, Semaphore* pSem = NULL, enum execute_mode_t mode = EXECUTE_AUTO);
bool post(Task* pTask, Semaphore* pSem, enum execute_mode_t mode);
bool post(Task* pTask, enum execute_mode_t mode)
{
return post(pTask, NULL, mode);
}
/**
* Posts a task to a worker for execution.
@ -742,10 +747,10 @@ public:
*
* @attention Once the task has been executed, it will be deleted.
*/
bool post(std::auto_ptr<DisposableTask> sTask, enum execute_mode_t mode = EXECUTE_AUTO);
bool post(std::auto_ptr<DisposableTask> sTask, enum execute_mode_t mode);
template<class T>
bool post(std::auto_ptr<T> sTask, enum execute_mode_t mode = EXECUTE_AUTO)
bool post(std::auto_ptr<T> sTask, enum execute_mode_t mode)
{
return post(std::auto_ptr<DisposableTask>(sTask.release()), mode);
}
@ -768,10 +773,11 @@ public:
* semaphore.
*
* @param func Function to execute
* @param mode Execution mode
*
* @return True if function was executed on the worker
*/
bool execute(GenericFunction func);
bool execute(GenericFunction func, enum execute_mode_t mode);
/**
* Post a message to a worker.
@ -933,7 +939,7 @@ protected:
pTask->dec_ref();
}
bool post_disposable(DisposableTask* pTask, enum execute_mode_t mode = EXECUTE_AUTO);
bool post_disposable(DisposableTask* pTask, enum execute_mode_t mode);
/**
* Called by Worker::run() before starting the epoll loop.