hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make block_size a size parameter

Browse Source 
The block_size signifies a size in bytes so it makes sense to change it to
the size type.
This commit is contained in:
Markus Mäkelä
2017-06-29 21:15:09 +03:00
parent 25fd5a8a93
commit a19d93380e
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Documentation/Routers/Avrorouter.md
View File

@ -174,7 +174,11 @@ data block. The default value is 1000 row events.
#### `block_size` #### `block_size`
The Avro data block size in bytes. The default is 16 kilobytes. Increase this The Avro data block size in bytes. The default is 16 kilobytes. Increase this
value if individual events in the binary logs are very large. value if individual events in the binary logs are very large. The value is a
size type parameter which means that it can also be defined with an SI
suffix. Refer to the
[Configuration Guide](../Getting-Started/Configuration-Guide.md) for more
details about size type parameters and how to use them.
## Module commands ## Module commands

4
server/modules/routing/avrorouter/avro.c
View File

@ -201,7 +201,7 @@ MXS_MODULE* MXS_CREATE_MODULE()
{"group_rows", MXS_MODULE_PARAM_COUNT, "1000"}, {"group_rows", MXS_MODULE_PARAM_COUNT, "1000"},
{"group_trx", MXS_MODULE_PARAM_COUNT, "1"}, {"group_trx", MXS_MODULE_PARAM_COUNT, "1"},
{"start_index", MXS_MODULE_PARAM_COUNT, "1"}, {"start_index", MXS_MODULE_PARAM_COUNT, "1"},
{"block_size", MXS_MODULE_PARAM_COUNT, "0"}, {"block_size", MXS_MODULE_PARAM_SIZE, "0"},
{"codec", MXS_MODULE_PARAM_ENUM, "null", MXS_MODULE_OPT_ENUM_UNIQUE, codec_values}, {"codec", MXS_MODULE_PARAM_ENUM, "null", MXS_MODULE_OPT_ENUM_UNIQUE, codec_values},
{MXS_END_MODULE_PARAMS} {MXS_END_MODULE_PARAMS}
} }
@ -425,7 +425,7 @@ createInstance(SERVICE *service, char **options)
inst->trx_target = config_get_integer(params, "group_trx"); inst->trx_target = config_get_integer(params, "group_trx");
inst->codec = config_get_enum(params, "codec", codec_values); inst->codec = config_get_enum(params, "codec", codec_values);
int first_file = config_get_integer(params, "start_index"); int first_file = config_get_integer(params, "start_index");
inst->block_size = config_get_integer(params, "block_size"); inst->block_size = config_get_size(params, "block_size");
MXS_CONFIG_PARAMETER *param = config_get_param(params, "source"); MXS_CONFIG_PARAMETER *param = config_get_param(params, "source");
inst->gtid.domain = 0; inst->gtid.domain = 0;