hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Printf format checking added to logging function.

Browse Source 
Printf format checking added to logging function and all
issues that were revealed by that fixed.
This commit is contained in:
Johan Wikman
2015-11-16 11:38:03 +02:00
parent 44df53d846
commit a355e1beef
26 changed files with 209 additions and 191 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/modules/filter/dbfwfilter.c
View File

@ -1394,7 +1394,7 @@ createInstance(char **options, FILTER_PARAMETER **params)
if(file_empty)
{
skygw_log_write(LOGFILE_ERROR,"dbfwfilter: File is empty: %s");
skygw_log_write(LOGFILE_ERROR,"dbfwfilter: File is empty: %s", filename);
free(filename);
err = true;
goto retblock;

2
server/modules/filter/regexfilter.c
View File

@ -270,7 +270,7 @@ createInstance(char **options, FILTER_PARAMETER **params)
char errbuffer[1024];
pcre2_get_error_message(errnumber, (PCRE2_UCHAR*) & errbuffer, sizeof(errbuffer));
LOGIF(LE, (skygw_log_write_flush(LOGFILE_ERROR,
"Error: regexfilter: Compiling regular expression '%s' failed at %d: %s\n",
"Error: regexfilter: Compiling regular expression '%s' failed at %lu: %s\n",
my_instance->match, erroffset, errbuffer)));
free_instance(my_instance);
return NULL;

10
server/modules/filter/tee.c
View File

@ -986,7 +986,7 @@ clientReply (FILTER* instance, void *session, GWBUF *reply)
#ifdef SS_DEBUG
else
{
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c: [%d] Waiting for a result set from %s session.",
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c: [%ld] Waiting for a result set from %s session.",
my_session->d_id,
branch == PARENT?"parent":"child");
}
@ -1002,7 +1002,7 @@ clientReply (FILTER* instance, void *session, GWBUF *reply)
if(my_session->eof[branch] >= min_eof)
{
#ifdef SS_DEBUG
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c [%d] %s received last EOF packet",
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c [%ld] %s received last EOF packet",
my_session->d_id,
branch == PARENT?"parent":"child");
#endif
@ -1051,7 +1051,7 @@ clientReply (FILTER* instance, void *session, GWBUF *reply)
{
route = true;
#ifdef SS_DEBUG
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c:[%d] Routing final packet of response set.",my_session->d_id);
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c:[%ld] Routing final packet of response set.",my_session->d_id);
#endif
}
}
@ -1059,7 +1059,7 @@ clientReply (FILTER* instance, void *session, GWBUF *reply)
!my_session->waiting[CHILD])
{
#ifdef SS_DEBUG
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c:[%d] Routing single packet response.",my_session->d_id);
skygw_log_write_flush(LOGFILE_DEBUG,"tee.c:[%ld] Routing single packet response.",my_session->d_id);
#endif
route = true;
}
@ -1068,7 +1068,7 @@ clientReply (FILTER* instance, void *session, GWBUF *reply)
if(route)
{
#ifdef SS_DEBUG
skygw_log_write_flush(LOGFILE_DEBUG, "tee.c:[%d] Routing buffer '%p' parent(waiting [%s] replies [%d] eof[%d])"
skygw_log_write_flush(LOGFILE_DEBUG, "tee.c:[%ld] Routing buffer '%p' parent(waiting [%s] replies [%d] eof[%d])"
" child(waiting [%s] replies[%d] eof [%d])",
my_session->d_id,
my_session->tee_replybuf,