hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes for NULL test for function returns such as malloc() - as reported by Coverity

Browse Source
This commit is contained in:
Mark Riddoch
2013-08-29 13:34:21 +02:00
parent 03725cabe3
commit a445b6ff37
4 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
server/modules/protocol/telnetd.c
View File

@ -257,6 +257,7 @@ telnetd_hangup(DCB *dcb)
* socket for the protocol.
*
* @param dcb The descriptor control block
* @return The number of new connections created
*/
static int
telnetd_accept(DCB *dcb)
@ -275,17 +276,25 @@ int n_connect = 0;
else
{
atomic_add(&dcb->stats.n_accepts, 1);
client = dcb_alloc();
if ((client = dcb_alloc()) == NULL)
{
return n_connect;
}
client->fd = so;
client->remote = strdup(inet_ntoa(addr.sin_addr));
memcpy(&client->func, &MyObject, sizeof(GWPROTOCOL));
client->session = session_alloc(dcb->session->service, client);
client->state = DCB_STATE_IDLE;
client->protocol = malloc(sizeof(TELNETD));
if ((client->protocol = malloc(sizeof(TELNETD))) == NULL)
{
dcb_free(client);
return n_connect;
}
if (poll_add_dcb(client) == -1)
{
dcb_free(client);
return n_connect;
}
n_connect++;