hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak when backend authentication fails

Browse Source 
If the backend authentication failed for a user, the buffer containing the
error packet would leak.
This commit is contained in:
Markus Mäkelä
2018-03-13 14:24:54 +02:00
parent 050e27685e
commit a75ea27a96
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/modules/protocol/MySQL/MySQLBackend/mysql_backend.c
View File

@ -401,7 +401,6 @@ mxs_auth_state_t handle_server_response(DCB *dcb, GWBUF *buffer)
} }
} }
gwbuf_free(buffer);
return rval; return rval;
} }
@ -498,7 +497,6 @@ gw_read_backend_event(DCB *dcb)
} }
proto->protocol_auth_state = state; proto->protocol_auth_state = state;
gwbuf_free(readbuf);
} }
else if (proto->protocol_auth_state == MXS_AUTH_STATE_RESPONSE_SENT) else if (proto->protocol_auth_state == MXS_AUTH_STATE_RESPONSE_SENT)
{ {
@ -527,6 +525,8 @@ gw_read_backend_event(DCB *dcb)
/** Authentication failed */ /** Authentication failed */
gw_reply_on_error(dcb, proto->protocol_auth_state); gw_reply_on_error(dcb, proto->protocol_auth_state);
} }
gwbuf_free(readbuf);
} }
else if (proto->protocol_auth_state == MXS_AUTH_STATE_CONNECTED && else if (proto->protocol_auth_state == MXS_AUTH_STATE_CONNECTED &&
dcb->ssl_state == SSL_ESTABLISHED) dcb->ssl_state == SSL_ESTABLISHED)