hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1220: Use PUT to set/clear server

Browse Source 
The correct method for set/clear endpoints is PUT, not POST, as the
resource always ends up in the desired state, regardless of its current
state.
This commit is contained in:
Markus Mäkelä
2017-06-30 16:04:37 +03:00
parent 30a40a090b
commit a8bfdac49c
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/core/test/rest-api/test/server.js
View File

@ -90,7 +90,7 @@ describe("Server Status", function() {
});
it("set server into maintenance", function() {
return request.post(base_url + "/servers/" + server.data.id + "/set?status=maintenance")
return request.put(base_url + "/servers/" + server.data.id + "/set?status=maintenance")
.then(function(resp) {
return request.get(base_url + "/servers/" + server.data.id)
})
@ -101,7 +101,7 @@ describe("Server Status", function() {
});
it("clear maintenance", function() {
return request.post(base_url + "/servers/" + server.data.id + "/clear?status=maintenance")
return request.put(base_url + "/servers/" + server.data.id + "/clear?status=maintenance")
.then(function(resp) {
return request.get(base_url + "/servers/" + server.data.id)
})
@ -112,12 +112,12 @@ describe("Server Status", function() {
});
it("set invalid status value", function() {
return request.post(base_url + "/servers/" + server.data.id + "/set?status=somethingstrange")
return request.put(base_url + "/servers/" + server.data.id + "/set?status=somethingstrange")
.should.be.rejected
});
it("clear invalid status value", function() {
return request.post(base_url + "/servers/" + server.data.id + "/clear?status=somethingstrange")
return request.put(base_url + "/servers/" + server.data.id + "/clear?status=somethingstrange")
.should.be.rejected
});