hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-3359 Change qla-filter append option to default to true

Browse Source 
Append to log files after a restart rather than overwrite.
This commit is contained in:
Niclas Antti
2021-08-20 11:05:03 +03:00
parent 8765eb88fa
commit aa6a1a58eb
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/Filters/Query-Log-All-Filter.md
View File

@ -118,7 +118,9 @@ flush=true
### `append` ### `append`
Append new entries to log files instead of overwriting them. The default is Append new entries to log files instead of overwriting them. The default is
false. true.
NOTE: the default was changed from false to true, as of the following
versions: 2.4.18, 2.5.16 and 6.2.
``` ```
append=true append=true

2
server/modules/filter/qlafilter/qlafilter.cc
View File

@ -1007,7 +1007,7 @@ extern "C" MXS_MODULE* MXS_CREATE_MODULE()
PARAM_FLUSH, MXS_MODULE_PARAM_BOOL, "false" PARAM_FLUSH, MXS_MODULE_PARAM_BOOL, "false"
}, },
{ {
PARAM_APPEND, MXS_MODULE_PARAM_BOOL, "false" PARAM_APPEND, MXS_MODULE_PARAM_BOOL, "true"
}, },
{MXS_END_MODULE_PARAMS} {MXS_END_MODULE_PARAMS}
} }

2
server/modules/filter/qlafilter/qlafilter.hh
View File

@ -100,7 +100,7 @@ public:
uint32_t log_file_data_flags {0}; /* What data is saved to the files */ uint32_t log_file_data_flags {0}; /* What data is saved to the files */
std::string filebase; /* The filename base */ std::string filebase; /* The filename base */
bool flush_writes {false}; /* Flush log file after every write? */ bool flush_writes {false}; /* Flush log file after every write? */
bool append {false}; /* Open files in append-mode? */ bool append {true}; /* Open files in append-mode? */
std::string query_newline; /* Character(s) used to replace a newline within a query */ std::string query_newline; /* Character(s) used to replace a newline within a query */
std::string separator; /* Character(s) used to separate elements */ std::string separator; /* Character(s) used to separate elements */
std::string user_name; /* The user name to filter on */ std::string user_name; /* The user name to filter on */