hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix possible crash on show sessions

Browse Source 
The function that printed all sessions assumed that all client DCBs had
valid, non-dummy sessions. It is possible that a client with a dummy
session is the list. These sessions should be ignored.
This commit is contained in:
Markus Mäkelä
2017-08-25 18:16:07 +03:00
parent bc889b1b41
commit abd99febcf
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/core/session.c
View File

@ -426,7 +426,8 @@ printAllSessions()
/** Callback for dprintAllSessions */ /** Callback for dprintAllSessions */
bool dprintAllSessions_cb(DCB *dcb, void *data) bool dprintAllSessions_cb(DCB *dcb, void *data)
{ {
if (dcb->dcb_role == DCB_ROLE_CLIENT_HANDLER) if (dcb->dcb_role == DCB_ROLE_CLIENT_HANDLER &&
dcb->session->state != SESSION_STATE_DUMMY)
{ {
DCB *out_dcb = (DCB*)data; DCB *out_dcb = (DCB*)data;
dprintSession(out_dcb, dcb->session); dprintSession(out_dcb, dcb->session);