hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix heap buffer overflow in blr

Browse Source 
The name printing wrote past the end of the buffer.
This commit is contained in:
Markus Mäkelä
2018-08-28 16:40:00 +03:00
parent d9ddf0f720
commit b2047aaa80
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/modules/routing/binlogrouter/blr_master.cc
View File

@ -392,11 +392,12 @@ blr_restart_master(ROUTER_INSTANCE *router)
/* Set reconnection task */ /* Set reconnection task */
static const char master[] = "Master"; static const char master[] = "Master";
char *name = (char *)MXS_MALLOC(strlen(router->service->name) + sizeof(master)); size_t sz = strlen(router->service->name) + sizeof(master) + 2;
char *name = (char *)MXS_MALLOC(sz);
if (name) if (name)
{ {
sprintf(name, "%s %s", router->service->name, master); snprintf(name, sz, "%s %s", router->service->name, master);
hktask_add(name, hktask_add(name,
blr_start_master_in_main, blr_start_master_in_main,
router, router,