hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed behaviour for a slave requesting master_log_pos beyond binlog file size

Browse Source 
Slave request for a log_pos behind binlog file size may result in a
disconnection or replication error:

if binlog file is latest one slave get disconnected otherwise an error
message is returned and replication stops
This commit is contained in:
MassimilianoPinto
2015-12-17 15:45:16 +01:00
parent 162e73f083
commit b55f100e1f
3 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/modules/routing/binlog/blr_file.c
View File

@ -432,8 +432,28 @@ struct stat statb;
if (pos > filelen)
{
snprintf(errmsg, BINLOG_ERROR_MSG_LEN, "Requested position %lu is beyond end of the binlog file '%s', size %lu",
pos, file->binlogname, filelen);
spinlock_acquire(&router->binlog_lock);
spinlock_acquire(&file->lock);
if (strcmp(router->binlog_name, file->binlogname) != 0)
{
snprintf(errmsg, BINLOG_ERROR_MSG_LEN, "Requested position %lu is beyond "
"'closed' binlog file '%s', size %lu. Generating Error '1236'",
pos, file->binlogname, filelen);
} else {
snprintf(errmsg, BINLOG_ERROR_MSG_LEN, "Requested position %lu is beyond "
"end of the latest binlog file '%s', size %lu. Disconnecting",
pos, file->binlogname, filelen);
/* Slave will be disconnected by the calling routine */
hdr->ok = SLAVE_POS_BEYOND_EOF;
}
}
spinlock_release(&file->lock);
spinlock_release(&router->binlog_lock);
return NULL;
}