hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1527 Do not consider sysvars to be updated in SELECT

Browse Source 
A statement like

    select if(@@hostname='box02','prod_mariadb02','n');

does not modify @@hostname. Hence the type mask should be
QUERY_TYPE_READ|QUERY_TYPE_SYSVAR_READ and NOT
QUERY_TYPE_READ|QUERY_TYPE_GSYSVAR_WRITE.
This commit is contained in:
Johan Wikman 2017-12-27 10:54:12 +02:00
parent 58373b3495
commit ba9b4a3bf6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
query_classifier/qc_sqlite/qc_sqlite.c
View File

@ -1023,7 +1023,10 @@ static void update_field_infos(QC_SQLITE_INFO* info,
{
if (zToken[1] == '@')
{
if ((prev_token == TK_EQ) && (pos == QC_TOKEN_LEFT))
// TODO: This should actually be "... && (info->operation == QUERY_OP_SET)"
// TODO: but there is no QUERY_OP_SET at the moment.
if ((prev_token == TK_EQ) && (pos == QC_TOKEN_LEFT) &&
(info->operation != QUERY_OP_SELECT))
{
info->type_mask |= QUERY_TYPE_GSYSVAR_WRITE;
}