hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2046: Fix additional memory leaks

Browse Source 
A set of memory leaks were revealed by Valgrind.
This commit is contained in:
Markus Mäkelä
2018-09-13 13:56:19 +03:00
parent ce602daf10
commit bee7cc2002
6 changed files with 35 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/modules/routing/binlogrouter/blr_file.c
View File

@ -1404,6 +1404,7 @@ blr_read_binlog(ROUTER_INSTANCE *router,
void
blr_close_binlog(ROUTER_INSTANCE *router, BLFILE *file)
{
ss_dassert(file);
spinlock_acquire(&router->fileslock);
file->refcnt--;
if (file->refcnt == 0)
@ -4055,6 +4056,7 @@ bool blr_save_mariadb_gtid(ROUTER_INSTANCE *inst)
{
if (sql_ret == SQLITE_CONSTRAINT)
{
sqlite3_free(errmsg);
/* Prepare UPDATE SQL */
snprintf(sql_stmt,
GTID_SQL_BUFFER_SIZE,
@ -4102,6 +4104,8 @@ bool blr_save_mariadb_gtid(ROUTER_INSTANCE *inst)
}
}
sqlite3_free(errmsg);
MXS_DEBUG("Saved/udated MariaDB GTID '%s', %s:%lu,%lu, SQL [%s]",
gtid_info.gtid,
inst->binlog_name,