From c167499c7b756340dd0e8fb89602806edf99e7a4 Mon Sep 17 00:00:00 2001 From: Johan Wikman Date: Mon, 23 Nov 2015 09:25:50 +0200 Subject: [PATCH] Add notice about previous failure to unlock. In blr_slave.c under certain conditions, two locks were not released. That was fixed in another change, and with this change a notice will be logged if that branch is entered. That way it will be possible to find out whether this may have been the cause of earlier lock-ups. --- server/modules/routing/binlog/blr_slave.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/modules/routing/binlog/blr_slave.c b/server/modules/routing/binlog/blr_slave.c index 43543ac5d..ae470b050 100644 --- a/server/modules/routing/binlog/blr_slave.c +++ b/server/modules/routing/binlog/blr_slave.c @@ -2117,7 +2117,11 @@ char read_errmsg[BINLOG_ERROR_MSG_LEN+1]; spinlock_release(&slave->catch_lock); spinlock_release(&router->binlog_lock); state_change = 1; - } else { + } + else + { + MXS_NOTICE("Execution entered branch were locks previously were NOT " + "released. Previously this would have caused a lock-up."); spinlock_release(&slave->catch_lock); spinlock_release(&router->binlog_lock); }