From c35d92eccceea83dcf703a75dbc2c904b1fca25d Mon Sep 17 00:00:00 2001
From: Johan Wikman <johan.wikman@mariadb.com>
Date: Wed, 22 May 2019 12:26:35 +0300
Subject: [PATCH] MXS-2481 Check that node-absense leads to Down

If MaxScale cannot ping the health-check port of a node, the
state of the node should become 'Down'.
---
 maxscale-system-test/clustrix_basics.cpp | 58 ++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/maxscale-system-test/clustrix_basics.cpp b/maxscale-system-test/clustrix_basics.cpp
index 75683174c..8dd4c5d7b 100644
--- a/maxscale-system-test/clustrix_basics.cpp
+++ b/maxscale-system-test/clustrix_basics.cpp
@@ -76,11 +76,69 @@ void check_for_servers(const MaxRest& maxrest)
                 mxb::join(dynamic_servers).c_str());
 }
 
+void expect_all_servers_to_be(const MaxRest& maxrest, const std::string& state)
+{
+    cout << "Expecting the state of all servers to be: " << state << endl;
+
+    TestConnections& test = maxrest.test();
+    auto servers = maxrest.list_servers();
+
+    for (const auto& server : servers)
+    {
+        cout << server.name << "(" << server.address << "): " << server.state << endl;
+        test.expect(server.state == state,
+                    "State of %s(%s) is '%s', expected '%s.",
+                    server.name.c_str(),
+                    server.address.c_str(),
+                    server.state.c_str(),
+                    state.c_str());
+    }
+}
+
+void check_state_change(const MaxRest& maxrest)
+{
+    TestConnections& test = maxrest.test();
+
+    expect_all_servers_to_be(maxrest, "Master, Running");
+    cout << endl;
+
+    int node = 0;
+    string address = test.clustrix->IP_private[node];
+
+    cout << "Blocking node: " << node << endl;
+    test.clustrix->block_node(node);
+
+    int cycles = 3;
+    cout << "Waiting for " << cycles << " monitor cycles." << endl;
+    test.maxscales->wait_for_monitor(cycles);
+
+    auto servers = maxrest.list_servers();
+
+    for (const auto& server : servers)
+    {
+        cout << server.name << "(" << server.address << "): " << server.state << endl;
+        if (server.address == address)
+        {
+            test.expect(server.state == "Down", "Blocked server was not 'Down' but '%s'.", server.state.c_str());
+        }
+    }
+
+    cout << endl;
+
+    test.clustrix->unblock_node(node);
+    cout << "Waiting for " << cycles << " monitor cycles." << endl;
+    test.maxscales->wait_for_monitor(cycles);
+
+    expect_all_servers_to_be(maxrest, "Master, Running");
+    cout << endl;
+}
+
 void run_test(TestConnections& test)
 {
     MaxRest maxrest(&test);
 
     check_for_servers(maxrest);
+    check_state_change(maxrest);
 }
 
 }