hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch '2.0' into develop

Browse Source
This commit is contained in:
Markus Makela
2016-09-20 22:36:35 +03:00
parent 62ab834e8a 715f978051
commit ca9021b835
17 changed files with 156 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
CMakeLists.txt
View File

@ -98,6 +98,11 @@ endif()
set(CMAKE_INSTALL_RPATH ${CMAKE_INSTALL_RPATH}:${CMAKE_INSTALL_PREFIX}/${MAXSCALE_LIBDIR}) set(CMAKE_INSTALL_RPATH ${CMAKE_INSTALL_RPATH}:${CMAKE_INSTALL_PREFIX}/${MAXSCALE_LIBDIR})
# Only do packaging if configured
if(PACKAGE)
include(cmake/package.cmake)
endif()
# Make sure the release notes for this release are present if it is a stable one # Make sure the release notes for this release are present if it is a stable one
if(${MAXSCALE_VERSION} MATCHES "-stable") if(${MAXSCALE_VERSION} MATCHES "-stable")
file(GLOB ${CMAKE_SOURCE_DIR}/Documentation/Release-Notes RELEASE_NOTES *${MAXSCALE_VERSION_NUMERIC}*.md) file(GLOB ${CMAKE_SOURCE_DIR}/Documentation/Release-Notes RELEASE_NOTES *${MAXSCALE_VERSION_NUMERIC}*.md)
@ -227,7 +232,6 @@ if(WITH_SCRIPTS)
include(cmake/init_scripts.cmake) include(cmake/init_scripts.cmake)
endif() endif()
# Only do packaging if configured
if(PACKAGE) if(PACKAGE)
# Install the files copied by the postinst script into the share folder # Install the files copied by the postinst script into the share folder
@ -236,9 +240,6 @@ if(PACKAGE)
install_program(${CMAKE_BINARY_DIR}/postinst core) install_program(${CMAKE_BINARY_DIR}/postinst core)
install_program(${CMAKE_BINARY_DIR}/postrm core) install_program(${CMAKE_BINARY_DIR}/postrm core)
# Include the package configuration
include(cmake/package.cmake)
# CPack needs to be included after everything is configured # CPack needs to be included after everything is configured
include(CPack) include(CPack)
endif() endif()

6
Documentation/Getting-Started/Building-MaxScale-from-Source-Code.md
View File

@ -88,6 +88,7 @@ _NAME_=_VALUE_ format (e.g. `-DBUILD_TESTS=Y`).
|WITH_SCRIPTS|Install systemd and init.d scripts| |WITH_SCRIPTS|Install systemd and init.d scripts|
|PACKAGE|Enable building of packages| |PACKAGE|Enable building of packages|
|TARGET_COMPONENT|Which component to install, default is the 'core' package. Other targets are 'experimental', which installs experimental packages, 'devel' which installs development headers and 'all' which installs all components.| |TARGET_COMPONENT|Which component to install, default is the 'core' package. Other targets are 'experimental', which installs experimental packages, 'devel' which installs development headers and 'all' which installs all components.|
|TARBALL|Build tar.gz packages, requires PACKAGE=Y|
**Note**: You can look into [defaults.cmake](../../cmake/defaults.cmake) for a **Note**: You can look into [defaults.cmake](../../cmake/defaults.cmake) for a
list of the CMake variables. list of the CMake variables.
@ -152,7 +153,10 @@ make
make package make package
``` ```
This will create a tarball and a RPM/DEB package. This will create a RPM/DEB package.
To build a tarball, add `-DTARBALL=Y` to the cmake invokation. This will create
a _maxscale-x.y.z.tar.gz_ file where _x.y.z_ is the version number.
Some Debian and Ubuntu systems suffer from a bug where `make package` fails Some Debian and Ubuntu systems suffer from a bug where `make package` fails
with errors from dpkg-shlibdeps. This can be fixed by running `make` before with errors from dpkg-shlibdeps. This can be fixed by running `make` before

12
Documentation/Getting-Started/Install-MariaDB-MaxScale-Using-a-Tarball.md
View File

@ -1,6 +1,6 @@
# Installing MariaDB MaxScale using a tarball # Installing MariaDB MaxScale using a tarball
MariaDB MaxScale is also made available as a tarball, which is named like `maxscale-X.Y.X.tar.gz` where `X.Y.Z` is the same as the corresponding version, e.g. `maxscale-2.0.1.tar.gz`. MariaDB MaxScale is also made available as a tarball, which is named like `maxscale-x.y.z.OS.tar.gz` where `x.y.z` is the same as the corresponding version and `OS` identifies the operating system, e.g. `maxscale-2.0.1.centos.7.tar.gz`.
The tarball has been built with the assumption that it will be installed in `/usr/local`. However, it is possible to install it in any directory, but in that case MariaDB MaxScale must be invoked with a flag. The tarball has been built with the assumption that it will be installed in `/usr/local`. However, it is possible to install it in any directory, but in that case MariaDB MaxScale must be invoked with a flag.
@ -13,8 +13,8 @@ The required steps are as follows:
$ sudo groupadd maxscale $ sudo groupadd maxscale
$ sudo useradd -g maxscale maxscale $ sudo useradd -g maxscale maxscale
$ cd /usr/local $ cd /usr/local
$ sudo tar -xzvf maxscale-X.Y.Z.tar.gz $ sudo tar -xzvf maxscale-x.y.z.OS.tar.gz
$ sudo ln -s maxscale-X.Y.Z maxscale $ sudo ln -s maxscale-x.y.z maxscale
$ cd maxscale $ cd maxscale
$ chown -R maxscale var $ chown -R maxscale var
@ -34,13 +34,13 @@ If you want to place the configuration file somewhere else but in `/etc` you can
Enter a directory where you have the right to create a subdirectory. Then do as follows. Enter a directory where you have the right to create a subdirectory. Then do as follows.
$ tar -xzvf maxscale-X.Y.Z.tar.gz $ tar -xzvf maxscale-x.y.z.OS.tar.gz
The next step is to create the MaxScale configuration file `maxscale-X.Y.Z/etc/maxscale.cnf`. The file `maxscale-X.Y.Z/etc/maxscale.cnf.template` can be used as a base. Please refer to [Configuration Guide](Configuration-Guide.md) for details. The next step is to create the MaxScale configuration file `maxscale-x.y.z/etc/maxscale.cnf`. The file `maxscale-x.y.z/etc/maxscale.cnf.template` can be used as a base. Please refer to [Configuration Guide](Configuration-Guide.md) for details.
When the configuration file has been created, MariaDB MaxScale can be started. When the configuration file has been created, MariaDB MaxScale can be started.
$ cd maxscale-X.Y.Z $ cd maxscale-x.y.z
$ LD_LIBRARY_PATH=lib/maxscale bin/maxscale -d --basedir=. $ LD_LIBRARY_PATH=lib/maxscale bin/maxscale -d --basedir=.
With the flag `--basedir`, MariaDB MaxScale is told where the `bin`, `etc`, `lib` With the flag `--basedir`, MariaDB MaxScale is told where the `bin`, `etc`, `lib`

38
Documentation/Getting-Started/MariaDB-MaxScale-Installation-Guide.md
View File

@ -6,21 +6,43 @@ In this introduction to MariaDB MaxScale the aim is to take the reader from the
## Installation ## Installation
The simplest way to install MariaDB MaxScale is to use one of the binary packages that are available for download from the MariaDB website. MariaDB MaxScale can be installed either using the MariaDB Enterprise Repository or directly from a downloaded package.
* Simply go to [http://www.mariadb.com/my_portal/download](http://www.mariadb.com/my_portal/download) ### Using the MariaDB Enterprise Repository
* Sign in to MariaDB.com * Go to [https://mariadb.com/my_portal/download](https://mariadb.com/my_portal/download).
* Follow the instructions at the top of the page. * Sign in or create an account for you.
![image alt text](images/getting_started.png) * Select your operating system and follow the instructions.
If you want to install only MariaDB MaxScale, further down you will find the product specific download pages. Click on the MariaDB MaxScale link and follow the distribution specific instructions. ### From a Downloaded Package
![image alt text](images/getting_started2.png) The MaxScale package can be downloaded from the following locations:
After you have installed MariaDB MaxScale, you can start it. * [https://mariadb.com/my_portal/download/maxscale](https://mariadb.com/my_portal/download/maxscale)
* [https://mariadb.com/downloads/maxscale](https://mariadb.com/downloads/maxscale)
Select your operating system and download the package.
Depending on your OS, the package will either be a _deb_ or an _rpm_.
An _rpm_ is installed as follows
```
$ sudo yum install path-to-maxscale-package.rpm
```
and a _deb_ as follows
```
$ sudo dpkg -i path-to-maxscale-package.deb
$ sudo apt-get install -f
```
### Starting MariaDB MaxScale
Before starting MariaDB MaxScale, you need to create a configuration file for it; please see further [down](#configuring-mariadb-maxscale).
Once a configuration file has been created you can start MariaDB MaxScale:
``` ```
systemctl start maxscale.service systemctl start maxscale.service

4
Documentation/Monitors/MySQL-Monitor.md
View File

@ -78,10 +78,6 @@ With this parameter, slaves that have lost their master but have been slaves of
a master server can retain their slave status even without a master. This means a master server can retain their slave status even without a master. This means
that when a slave loses its master, it can still be used for reads. that when a slave loses its master, it can still be used for reads.
If MaxScale loses the connection to the slave, the slave will lose the stale
slave state because MaxScale doesn't know if the slave has had recent contact
with the master server.
If this feature is disabled, a server is considered a valid slave if and only if If this feature is disabled, a server is considered a valid slave if and only if
it has a running master server monitored by this monitor. it has a running master server monitored by this monitor.

14
Documentation/Release-Notes/MaxScale-2.0.1-Release-Notes.md
View File

@ -113,13 +113,17 @@ Please consult
## Bug fixes ## Bug fixes
[Here is a list of bugs fixed since the release of MaxScale 2.0.1.](https://jira.mariadb.org/issues/?jql=project%20%3D%20MXS%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20in%20(2.0.0%2C%202.0.1)%20AND%20resolved%20%3E%3D%20-21d%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC) [Here is a list of bugs fixed since the release of MaxScale 2.0.0.](https://jira.mariadb.org/browse/MXS-860?jql=project%20%3D%20MXS%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20in%20(2.0.1)%20AND%20resolved%20%3E%3D%20-21d%20AND%20(resolution%20%3D%20Done%20OR%20resolution%20%3D%20Fixed)%20ORDER%20BY%20priority%20DESC)
* [MXS-812](https://jira.mariadb.org/browse/MXS-812): Number of conns not matching number of operations * [MXS-860](https://jira.mariadb.org/browse/MXS-860): I want to access the web site if master server is down
* [MXS-847](https://jira.mariadb.org/browse/MXS-847): server_down event is executed 8 times due to putting sever into maintenance mode * [MXS-870](https://jira.mariadb.org/browse/MXS-870): Assertion of Buffer Overflow
* [MXS-845](https://jira.mariadb.org/browse/MXS-845): "Server down" event is re-triggered after maintenance mode is repeated * [MXS-845](https://jira.mariadb.org/browse/MXS-845): "Server down" event is re-triggered after maintenance mode is repeated
* [MXS-842](https://jira.mariadb.org/browse/MXS-842): Unexpected / undocumented behaviour when multiple available masters from mmmon monitor * [MXS-836](https://jira.mariadb.org/browse/MXS-836): "Failed to start all MaxScale services" without retrying
* [MXS-846](https://jira.mariadb.org/browse/MXS-846): MMMon: Maintenance mode on slave logs error message every second * [MXS-835](https://jira.mariadb.org/browse/MXS-835): Please reinstate remote access to maxscaled protocol
* [MXS-773](https://jira.mariadb.org/browse/MXS-773): 100% CPU on idle MaxScale with MaxInfo
* [MXS-812](https://jira.mariadb.org/browse/MXS-812): Number of conns not matching number of operations
* [MXS-856](https://jira.mariadb.org/browse/MXS-856): If config file cannot be accessed and creation of log file fails, MaxScale crashes with SIGSEGV
* [MXS-829](https://jira.mariadb.org/browse/MXS-829): When the config file isn't readable or doesn't exist, maxscale silently ends
## Known Issues and Limitations ## Known Issues and Limitations

4
VERSION.cmake
View File

@ -5,10 +5,10 @@
set(MAXSCALE_VERSION_MAJOR "2" CACHE STRING "Major version") set(MAXSCALE_VERSION_MAJOR "2" CACHE STRING "Major version")
set(MAXSCALE_VERSION_MINOR "0" CACHE STRING "Minor version") set(MAXSCALE_VERSION_MINOR "0" CACHE STRING "Minor version")
set(MAXSCALE_VERSION_PATCH "0" CACHE STRING "Patch version") set(MAXSCALE_VERSION_PATCH "1" CACHE STRING "Patch version")
# This should only be incremented if a package is rebuilt # This should only be incremented if a package is rebuilt
set(MAXSCALE_BUILD_NUMBER 1 CACHE STRING "Release number") set(MAXSCALE_BUILD_NUMBER 1 CACHE STRING "Release number")
set(MAXSCALE_VERSION_NUMERIC "${MAXSCALE_VERSION_MAJOR}.${MAXSCALE_VERSION_MINOR}.${MAXSCALE_VERSION_PATCH}") set(MAXSCALE_VERSION_NUMERIC "${MAXSCALE_VERSION_MAJOR}.${MAXSCALE_VERSION_MINOR}.${MAXSCALE_VERSION_PATCH}")
set(MAXSCALE_VERSION "beta-${MAXSCALE_VERSION_MAJOR}.${MAXSCALE_VERSION_MINOR}.${MAXSCALE_VERSION_PATCH}") set(MAXSCALE_VERSION "${MAXSCALE_VERSION_MAJOR}.${MAXSCALE_VERSION_MINOR}.${MAXSCALE_VERSION_PATCH}")

32
cmake/package.cmake
View File

@ -33,20 +33,22 @@ endif()
find_program(RPMBUILD rpmbuild) find_program(RPMBUILD rpmbuild)
find_program(DEBBUILD dpkg-buildpackage) find_program(DEBBUILD dpkg-buildpackage)
message(STATUS "Generating TGZ packages") if(TARBALL)
set(CPACK_GENERATOR "TGZ") include(cmake/package_tgz.cmake)
if(NOT ( ${RPMBUILD} STREQUAL "RPMBUILD-NOTFOUND" ) ) elseif (NOT ( ${RPMBUILD} STREQUAL "RPMBUILD-NOTFOUND" ) OR NOT ( ${DEBBUILD} STREQUAL "DEBBUILD-NOTFOUND" ))
include(cmake/package_rpm.cmake) if(NOT ( ${RPMBUILD} STREQUAL "RPMBUILD-NOTFOUND" ) )
message(STATUS "Generating RPM packages") include(cmake/package_rpm.cmake)
set(PACKAGE_SUFFIX "rpm") endif()
set(RPM TRUE CACHE INTERNAL "RPM based installation") if(NOT ( ${DEBBUILD} STREQUAL "DEBBUILD-NOTFOUND" ) )
elseif(NOT ( ${DEBBUILD} STREQUAL "DEBBUILD-NOTFOUND" ) ) include(cmake/package_deb.cmake)
include(cmake/package_deb.cmake) endif()
message(STATUS "Generating DEB packages for ${DEB_ARCHITECTURE}")
set(PACKAGE_SUFFIX "deb") message(STATUS "You can install startup scripts and system configuration files for MaxScale by running the 'postinst' shell script located at ${CMAKE_INSTALL_PREFIX}.")
set(DEB TRUE CACHE INTERNAL "DEB based installation") message(STATUS "To remove these installed files, run the 'postrm' shell script located in the same folder.")
else()
message(FATAL_ERROR "Could not automatically resolve the package generator and no generators "
"defined on the command line. Please install distribution specific packaging software or "
"define -DTARBALL=Y to build tar.gz packages.")
endif() endif()
message(STATUS "You can install startup scripts and system configuration files for MaxScale by running the 'postinst' shell script located at ${CMAKE_INSTALL_PREFIX}.")
message(STATUS "To remove these installed files, run the 'postrm' shell script located in the same folder.")

2
cmake/package_deb.cmake
View File

@ -12,3 +12,5 @@ endif()
if(EXTRA_PACKAGE_DEPENDENCIES) if(EXTRA_PACKAGE_DEPENDENCIES)
set(CPACK_DEBIAN_PACKAGE_DEPENDS "${EXTRA_PACKAGE_DEPENDENCIES}") set(CPACK_DEBIAN_PACKAGE_DEPENDS "${EXTRA_PACKAGE_DEPENDENCIES}")
endif() endif()
message(STATUS "Generating DEB packages for ${DEB_ARCHITECTURE}")

2
cmake/package_rpm.cmake
View File

@ -32,3 +32,5 @@ endif()
if(EXTRA_PACKAGE_DEPENDENCIES) if(EXTRA_PACKAGE_DEPENDENCIES)
set(CPACK_RPM_PACKAGE_REQUIRES "${EXTRA_PACKAGE_DEPENDENCIES}") set(CPACK_RPM_PACKAGE_REQUIRES "${EXTRA_PACKAGE_DEPENDENCIES}")
endif() endif()
message(STATUS "Generating RPM packages")

19
cmake/package_tgz.cmake Normal file
View File

@ -0,0 +1,19 @@
# Tarball package configuration
message(STATUS "Generating tar.gz packages")
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH FALSE)
set(MAXSCALE_BINDIR /bin CACHE PATH "" FORCE)
set(MAXSCALE_LIBDIR /lib CACHE PATH "" FORCE)
set(MAXSCALE_SHAREDIR /share CACHE PATH "" FORCE)
set(MAXSCALE_DOCDIR /share CACHE PATH "" FORCE)
set(MAXSCALE_VARDIR /var CACHE PATH "" FORCE)
set(MAXSCALE_CONFDIR /etc CACHE PATH "" FORCE)
set(CMAKE_INSTALL_PREFIX "/" CACHE PATH "" FORCE)
set(CMAKE_INSTALL_RPATH "$ORIGIN/../lib" CACHE PATH "" FORCE)
set(CMAKE_INSTALL_DATADIR /share CACHE PATH "" FORCE)
set(CPACK_GENERATOR "TGZ")
if(DISTRIB_SUFFIX)
set(CPACK_PACKAGE_FILE_NAME "maxscale-${MAXSCALE_VERSION}.${DISTRIB_SUFFIX}")
else()
set(CPACK_PACKAGE_FILE_NAME "maxscale-${MAXSCALE_VERSION}")
endif()

6
server/core/buffer.c
View File

@ -380,9 +380,9 @@ GWBUF* gwbuf_clone_all(GWBUF* buf)
} }
GWBUF *gwbuf_clone_portion(GWBUF *buf, static GWBUF *gwbuf_clone_portion(GWBUF *buf,
size_t start_offset, size_t start_offset,
size_t length) size_t length)
{ {
GWBUF* clonebuf; GWBUF* clonebuf;

9
server/core/test/testbuffer.c
View File

@ -377,15 +377,6 @@ test1()
gwbuf_free(clone); gwbuf_free(clone);
ss_dfprintf(stderr, "Freed cloned buffer"); ss_dfprintf(stderr, "Freed cloned buffer");
ss_dfprintf(stderr, "\t..done\n"); ss_dfprintf(stderr, "\t..done\n");
partclone = gwbuf_clone_portion(buffer, 25, 50);
buflen = GWBUF_LENGTH(partclone);
ss_dfprintf(stderr, "Part cloned buffer length is now %d", buflen);
ss_info_dassert(50 == buflen, "Incorrect buffer size");
ss_info_dassert(0 == GWBUF_EMPTY(partclone), "Part cloned buffer should not be empty");
ss_dfprintf(stderr, "\t..done\n");
gwbuf_free(partclone);
ss_dfprintf(stderr, "Freed part cloned buffer");
ss_dfprintf(stderr, "\t..done\n");
buffer = gwbuf_consume(buffer, bite1); buffer = gwbuf_consume(buffer, bite1);
ss_info_dassert(NULL != buffer, "Buffer should not be null"); ss_info_dassert(NULL != buffer, "Buffer should not be null");
buflen = GWBUF_LENGTH(buffer); buflen = GWBUF_LENGTH(buffer);

1
server/include/buffer.h
View File

@ -197,7 +197,6 @@ extern unsigned int gwbuf_length(GWBUF *head);
extern int gwbuf_count(GWBUF *head); extern int gwbuf_count(GWBUF *head);
extern size_t gwbuf_copy_data(GWBUF *buffer, size_t offset, size_t bytes, extern size_t gwbuf_copy_data(GWBUF *buffer, size_t offset, size_t bytes,
uint8_t* dest); uint8_t* dest);
extern GWBUF *gwbuf_clone_portion(GWBUF *head, size_t offset, size_t len);
extern GWBUF *gwbuf_split(GWBUF **buf, size_t length); extern GWBUF *gwbuf_split(GWBUF **buf, size_t length);
extern GWBUF *gwbuf_clone_transform(GWBUF *head, gwbuf_type_t type); extern GWBUF *gwbuf_clone_transform(GWBUF *head, gwbuf_type_t type);
extern GWBUF *gwbuf_clone_all(GWBUF* head); extern GWBUF *gwbuf_clone_all(GWBUF* head);

10
server/modules/monitor/mysqlmon/mysql_mon.c
View File

@ -1127,10 +1127,6 @@ monitorMain(void *arg)
{ {
dcb_hangup_foreach(ptr->server); dcb_hangup_foreach(ptr->server);
} }
} }
if (mon_status_changed(ptr)) if (mon_status_changed(ptr))
@ -1225,6 +1221,8 @@ monitorMain(void *arg)
ptr = mon->databases; ptr = mon->databases;
while (ptr) while (ptr)
{ {
MYSQL_SERVER_INFO *serv_info = hashtable_fetch(handle->server_info, ptr->server->unique_name);
ss_dassert(serv_info);
if (!SERVER_IN_MAINT(ptr->server)) if (!SERVER_IN_MAINT(ptr->server))
{ {
/** If "detect_stale_master" option is On, let's use the previous master. /** If "detect_stale_master" option is On, let's use the previous master.
@ -1287,6 +1285,10 @@ monitorMain(void *arg)
{ {
ptr->pending_status |= SERVER_SLAVE; ptr->pending_status |= SERVER_SLAVE;
} }
else if (root_master == NULL && serv_info->slave_configured)
{
ptr->pending_status |= SERVER_SLAVE;
}
} }
ptr->server->status = ptr->pending_status; ptr->server->status = ptr->pending_status;

73
server/modules/protocol/MySQLBackend/mysql_backend.c
View File

@ -1185,48 +1185,38 @@ static int gw_write_backend_event(DCB *dcb)
*/ */
if (dcb->state != DCB_STATE_POLLING) if (dcb->state != DCB_STATE_POLLING)
{ {
uint8_t* data; uint8_t* data = NULL;
bool com_quit = false;
if (dcb->writeq != NULL) spinlock_acquire(&dcb->writeqlock);
if (dcb->writeq)
{ {
data = (uint8_t *) GWBUF_DATA(dcb->writeq); data = (uint8_t *) GWBUF_DATA(dcb->writeq);
com_quit = MYSQL_IS_COM_QUIT(data);
rc = 0;
}
spinlock_release(&dcb->writeqlock);
if (dcb->session->client_dcb == NULL)
{
rc = 0;
}
else if (!(MYSQL_IS_COM_QUIT(data)))
{
/*< vraa : errorHandle */
mysql_send_custom_error(dcb->session->client_dcb,
1,
0,
"Writing to backend failed due invalid Maxscale "
"state.");
MXS_DEBUG("%lu [gw_write_backend_event] Write to backend "
"dcb %p fd %d "
"failed due invalid state %s.",
pthread_self(),
dcb,
dcb->fd,
STRDCBSTATE(dcb->state));
MXS_ERROR("Attempt to write buffered data to backend " if (data && !com_quit)
"failed " {
"due internal inconsistent state."); mysql_send_custom_error(dcb->session->client_dcb, 1, 0,
"Writing to backend failed due invalid Maxscale state.");
MXS_DEBUG("%lu [gw_write_backend_event] Write to backend "
"dcb %p fd %d failed due invalid state %s.",
pthread_self(), dcb, dcb->fd, STRDCBSTATE(dcb->state));
rc = 0; MXS_ERROR("Attempt to write buffered data to backend "
} "failed due internal inconsistent state.");
} }
else else
{ {
MXS_DEBUG("%lu [gw_write_backend_event] Dcb %p in state %s " MXS_DEBUG("%lu [gw_write_backend_event] Dcb %p in state %s "
"but there's nothing to write either.", "but there's nothing to write either.",
pthread_self(), pthread_self(), dcb, STRDCBSTATE(dcb->state));
dcb,
STRDCBSTATE(dcb->state));
rc = 1; rc = 1;
} }
goto return_rc; goto return_rc;
} }
@ -2031,22 +2021,17 @@ static GWBUF* process_response_data(DCB* dcb,
outbuf = gwbuf_append(outbuf, readbuf); outbuf = gwbuf_append(outbuf, readbuf);
readbuf = NULL; readbuf = NULL;
} }
/** /**
* Packet was read. There should be more since bytes were * Buffer contains more data than we need. Split the complete packet and
* left over. * the extra data into two separate buffers.
* Move the next packet to its own buffer and add that next */
* to the prev packet's buffer. else
*/
else /*< nbytes_left < nbytes_to_process */
{ {
ss_dassert(nbytes_left >= 0); ss_dassert(nbytes_left < nbytes_to_process);
nbytes_to_process -= nbytes_left; ss_dassert(nbytes_left > 0);
/** Move the prefix of the buffer to outbuf from redbuf */
outbuf = gwbuf_append(outbuf,
gwbuf_clone_portion(readbuf, 0, (size_t) nbytes_left));
readbuf = gwbuf_consume(readbuf, (size_t) nbytes_left);
ss_dassert(npackets_left > 0); ss_dassert(npackets_left > 0);
outbuf = gwbuf_append(outbuf, gwbuf_split(&readbuf, nbytes_left));
nbytes_to_process -= nbytes_left;
npackets_left -= 1; npackets_left -= 1;
nbytes_left = 0; nbytes_left = 0;
} }

34
server/modules/routing/readwritesplit/readwritesplit.c
View File

@ -651,7 +651,7 @@ static void closeSession(ROUTER *instance, void *router_session)
} }
#endif #endif
/** Clean operation counter in bref and in SERVER */ /** Clean operation counter in bref and in SERVER */
while (BREF_IS_WAITING_RESULT(bref)) if (BREF_IS_WAITING_RESULT(bref))
{ {
bref_clear_state(bref, BREF_WAITING_RESULT); bref_clear_state(bref, BREF_WAITING_RESULT);
} }
@ -664,6 +664,10 @@ static void closeSession(ROUTER *instance, void *router_session)
/** decrease server current connection counters */ /** decrease server current connection counters */
atomic_add(&bref->bref_backend->backend_conn_count, -1); atomic_add(&bref->bref_backend->backend_conn_count, -1);
} }
else
{
ss_dassert(!BREF_IS_WAITING_RESULT(bref));
}
} }
/** Unlock */ /** Unlock */
rses_end_locked_router_action(router_cli_ses); rses_end_locked_router_action(router_cli_ses);
@ -1121,6 +1125,10 @@ static void handleError(ROUTER *instance, void *router_session,
if (bref != NULL) if (bref != NULL)
{ {
CHK_BACKEND_REF(bref); CHK_BACKEND_REF(bref);
if (BREF_IS_WAITING_RESULT(bref))
{
bref_clear_state(bref, BREF_WAITING_RESULT);
}
bref_clear_state(bref, BREF_IN_USE); bref_clear_state(bref, BREF_IN_USE);
bref_set_state(bref, BREF_CLOSED); bref_set_state(bref, BREF_CLOSED);
} }
@ -1281,7 +1289,6 @@ void rses_end_locked_router_action(ROUTER_CLIENT_SES *rses)
* @param bref The backend reference to be modified * @param bref The backend reference to be modified
* @param state A bit string where the 1 bits indicate bits that should * @param state A bit string where the 1 bits indicate bits that should
* be turned off in the bref state. * be turned off in the bref state.
*
*/ */
void bref_clear_state(backend_ref_t *bref, bref_state_t state) void bref_clear_state(backend_ref_t *bref, bref_state_t state)
{ {
@ -1290,11 +1297,8 @@ void bref_clear_state(backend_ref_t *bref, bref_state_t state)
MXS_ERROR("[%s] Error: NULL parameter.", __FUNCTION__); MXS_ERROR("[%s] Error: NULL parameter.", __FUNCTION__);
return; return;
} }
if (state != BREF_WAITING_RESULT)
{ if ((state & BREF_WAITING_RESULT) && (bref->bref_state & BREF_WAITING_RESULT))
bref->bref_state &= ~state;
}
else
{ {
int prev1; int prev1;
int prev2; int prev2;
@ -1319,6 +1323,8 @@ void bref_clear_state(backend_ref_t *bref, bref_state_t state)
} }
} }
} }
bref->bref_state &= ~state;
} }
/* /*
@ -1332,7 +1338,6 @@ void bref_clear_state(backend_ref_t *bref, bref_state_t state)
* @param bref The backend reference to be modified * @param bref The backend reference to be modified
* @param state A bit string where the 1 bits indicate bits that should * @param state A bit string where the 1 bits indicate bits that should
* be turned on in the bref state. * be turned on in the bref state.
*
*/ */
void bref_set_state(backend_ref_t *bref, bref_state_t state) void bref_set_state(backend_ref_t *bref, bref_state_t state)
{ {
@ -1341,11 +1346,8 @@ void bref_set_state(backend_ref_t *bref, bref_state_t state)
MXS_ERROR("[%s] Error: NULL parameter.", __FUNCTION__); MXS_ERROR("[%s] Error: NULL parameter.", __FUNCTION__);
return; return;
} }
if (state != BREF_WAITING_RESULT)
{ if ((state & BREF_WAITING_RESULT) && (bref->bref_state & BREF_WAITING_RESULT) == 0)
bref->bref_state |= state;
}
else
{ {
int prev1; int prev1;
int prev2; int prev2;
@ -1371,6 +1373,8 @@ void bref_set_state(backend_ref_t *bref, bref_state_t state)
bref->bref_backend->backend_server->port); bref->bref_backend->backend_server->port);
} }
} }
bref->bref_state |= state;
} }
/** /**
@ -1684,6 +1688,10 @@ static void handle_error_reply_client(SESSION *ses, ROUTER_CLIENT_SES *rses,
CHK_BACKEND_REF(bref); CHK_BACKEND_REF(bref);
bref_clear_state(bref, BREF_IN_USE); bref_clear_state(bref, BREF_IN_USE);
bref_set_state(bref, BREF_CLOSED); bref_set_state(bref, BREF_CLOSED);
if (BREF_IS_WAITING_RESULT(bref))
{
bref_clear_state(bref, BREF_WAITING_RESULT);
}
} }
if (sesstate == SESSION_STATE_ROUTER_READY) if (sesstate == SESSION_STATE_ROUTER_READY)