hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CHAGE MASTER TO new binlog requires MASTER_LOG_POS to be set

Browse Source 
CHAGE MASTER TO new binlog requires MASTER_LOG_POS to be set
This commit is contained in:
MassimilianoPinto
2015-06-23 17:42:42 +02:00
parent 543873a44f
commit cd7f7aba57
1 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
server/modules/routing/binlog/blr_slave.c
View File

@ -2496,16 +2496,33 @@ int blr_handle_change_master(ROUTER_INSTANCE* router, char *command, char *error
/* if binlog name has changed to next one only position 4 is allowed */ /* if binlog name has changed to next one only position 4 is allowed */
if (strcmp(master_logfile, router->binlog_name)) { if (strcmp(master_logfile, router->binlog_name)) {
if (pos > 0 && pos != 4) { int return_error = 0;
if (master_log_pos == NULL) {
snprintf(error, BINLOG_ERROR_MSG_LEN, "Can not set MASTER_LOG_POS to %s for MASTER_LOG_FILE %s: " snprintf(error, BINLOG_ERROR_MSG_LEN, "Please provide an explicit MASTER_LOG_POS for new MASTER_LOG_FILE %s: "
"Permitted binlog pos is %d. Current master_log_file=%s, master_log_pos=%lu", "Permitted binlog pos is %d. Current master_log_file=%s, master_log_pos=%lu",
passed_pos,
master_logfile, master_logfile,
4, 4,
router->binlog_name, router->binlog_name,
router->binlog_position); router->binlog_position);
return_error = 1;
} else {
if (pos != 4) {
snprintf(error, BINLOG_ERROR_MSG_LEN, "Can not set MASTER_LOG_POS to %s for MASTER_LOG_FILE %s: "
"Permitted binlog pos is %d. Current master_log_file=%s, master_log_pos=%lu",
passed_pos,
master_logfile,
4,
router->binlog_name,
router->binlog_position);
return_error = 1;
}
}
/* return an error or set new binlog name at pos 4 */
if (return_error) {
LOGIF(LE, (skygw_log_write_flush(LOGFILE_ERROR, "%s: %s", router->service->name, error))); LOGIF(LE, (skygw_log_write_flush(LOGFILE_ERROR, "%s: %s", router->service->name, error)));
if (master_log_pos) if (master_log_pos)
@ -2520,7 +2537,7 @@ int blr_handle_change_master(ROUTER_INSTANCE* router, char *command, char *error
return -1; return -1;
} else { } else {
/* set new filename and pos */ /* set new filename at pos 4 */
memset(router->binlog_name, '\0', sizeof(router->binlog_name)); memset(router->binlog_name, '\0', sizeof(router->binlog_name));
strncpy(router->binlog_name, master_logfile, BINLOG_FNAMELEN); strncpy(router->binlog_name, master_logfile, BINLOG_FNAMELEN);