From fd875cbf6df56247375424397c62beae7fe74b74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=A4kel=C3=A4?= Date: Tue, 11 Feb 2020 10:09:25 +0200 Subject: [PATCH] Remove faulty debug assertion The use of the server state is not transactional across multiple uses of the function. This means that any assertions on the target state can fail if the monitor updates the state between target selection and the assertion. --- server/modules/routing/readwritesplit/rwsplit_route_stmt.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc b/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc index c5fcc4701..3d18a8237 100644 --- a/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc +++ b/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc @@ -934,7 +934,6 @@ SRWBackend RWSplitSession::handle_slave_is_target(uint8_t cmd, uint32_t stmt_id) { mxb::atomic::add(&m_router->stats().n_slave, 1, mxb::atomic::RELAXED); m_server_stats[target->server()].read++; - mxb_assert(target->in_use() || target->can_connect()); } else {