diff --git a/Documentation/REST-API/Resources-Monitor.md b/Documentation/REST-API/Resources-Monitor.md index 75cca9a9c..8f847a10f 100644 --- a/Documentation/REST-API/Resources-Monitor.md +++ b/Documentation/REST-API/Resources-Monitor.md @@ -269,7 +269,7 @@ The :name in the URI must map to a monitor name with all whitespace replaced wit hyphens. The request body must be a valid JSON document representing the modified monitor. ``` -PATCH /v1/monitor/:name +PATCH /v1/monitors/:name ``` ### Modifiable Fields @@ -353,7 +353,7 @@ servers and if it does a PATCH request which removes these relationships is required before a DELETE request for the monitor can be made. ``` -DELETE /v1/monitor/:name/stop +DELETE /v1/monitors/:name/stop ``` #### Response @@ -371,7 +371,7 @@ Monitor could not be deleted: Stops a started monitor. ``` -PUT /v1/monitor/:name/stop +PUT /v1/monitors/:name/stop ``` #### Response @@ -385,7 +385,7 @@ Monitor is stopped: Starts a stopped monitor. ``` -PUT /v1/monitor/:name/start +PUT /v1/monitors/:name/start ``` #### Response diff --git a/maxscale-system-test/different_size.cpp b/maxscale-system-test/different_size.cpp index 363d44b87..acdf9bb3b 100644 --- a/maxscale-system-test/different_size.cpp +++ b/maxscale-system-test/different_size.cpp @@ -100,6 +100,7 @@ void different_packet_size(TestConnections* Test, bool binlog) Test->tprintf("Restoring max_allowed_packet"); set_max_packet(Test, binlog, (char*) "set global max_allowed_packet = 1048576;"); + Test->set_timeout(300); conn = connect_to_serv(Test, binlog); Test->try_query(conn, "DROP TABLE test.large_event"); mysql_close(conn); diff --git a/maxscale-system-test/different_size_rwsplit.cpp b/maxscale-system-test/different_size_rwsplit.cpp index dc9c94ada..ecfcd49e6 100644 --- a/maxscale-system-test/different_size_rwsplit.cpp +++ b/maxscale-system-test/different_size_rwsplit.cpp @@ -19,6 +19,7 @@ int main(int argc, char* argv[]) different_packet_size(Test, false); + Test->set_timeout(180); Test->repl->sync_slaves(); Test->check_maxscale_alive(0); int rval = Test->global_result; diff --git a/maxscale-system-test/mdbci/cnf/galera_server1.cnf b/maxscale-system-test/mdbci/cnf/galera_server1.cnf index 03b37157b..a378434b0 100644 --- a/maxscale-system-test/mdbci/cnf/galera_server1.cnf +++ b/maxscale-system-test/mdbci/cnf/galera_server1.cnf @@ -1,7 +1,7 @@ [mysqld] expire_logs_days=7 user=mysql -server_id=1 +server_id=101 wsrep_on=ON # Row binary log format is required by Galera diff --git a/maxscale-system-test/mdbci/cnf/galera_server2.cnf b/maxscale-system-test/mdbci/cnf/galera_server2.cnf index 79454a443..acfc2a358 100644 --- a/maxscale-system-test/mdbci/cnf/galera_server2.cnf +++ b/maxscale-system-test/mdbci/cnf/galera_server2.cnf @@ -1,7 +1,7 @@ [mysqld] expire_logs_days=7 user=mysql -server_id=2 +server_id=102 wsrep_on=ON # Row binary log format is required by Galera diff --git a/maxscale-system-test/mdbci/cnf/galera_server3.cnf b/maxscale-system-test/mdbci/cnf/galera_server3.cnf index 9f77a5687..a393b7613 100644 --- a/maxscale-system-test/mdbci/cnf/galera_server3.cnf +++ b/maxscale-system-test/mdbci/cnf/galera_server3.cnf @@ -1,7 +1,7 @@ [mysqld] expire_logs_days=7 user=mysql -server_id=3 +server_id=103 wsrep_on=ON # Row binary log format is required by Galera diff --git a/maxscale-system-test/mdbci/cnf/galera_server4.cnf b/maxscale-system-test/mdbci/cnf/galera_server4.cnf index a589a690e..2854acf02 100644 --- a/maxscale-system-test/mdbci/cnf/galera_server4.cnf +++ b/maxscale-system-test/mdbci/cnf/galera_server4.cnf @@ -1,7 +1,7 @@ [mysqld] expire_logs_days=7 user=mysql -server_id=4 +server_id=104 wsrep_on=ON # Row binary log format is required by Galera diff --git a/server/modules/authenticator/MySQLAuth/dbusers.cc b/server/modules/authenticator/MySQLAuth/dbusers.cc index 44ea9dd0c..19f5982c2 100644 --- a/server/modules/authenticator/MySQLAuth/dbusers.cc +++ b/server/modules/authenticator/MySQLAuth/dbusers.cc @@ -1046,7 +1046,8 @@ static int get_users(SERV_LISTENER* listener, bool skip_local) for (server = service->dbref; !maxscale_is_shutting_down() && server; server = server->next) { if (!SERVER_REF_IS_ACTIVE(server) || !server_is_active(server->server) - || (skip_local && server_is_mxs_service(server->server))) + || (skip_local && server_is_mxs_service(server->server)) + || !server_is_running(server->server)) { continue; } diff --git a/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc b/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc index 5bd369f51..9a08cd0b8 100644 --- a/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc +++ b/server/modules/routing/readwritesplit/rwsplit_route_stmt.cc @@ -419,6 +419,7 @@ bool RWSplitSession::route_session_write(GWBUF* querybuf, uint8_t command, uint3 } MXS_INFO("Session write, routing to all servers."); + bool attempted_write = false; for (auto it = m_backends.begin(); it != m_backends.end(); it++) { @@ -426,6 +427,7 @@ bool RWSplitSession::route_session_write(GWBUF* querybuf, uint8_t command, uint3 if (backend->in_use()) { + attempted_write = true; backend->append_session_command(sescmd); uint64_t current_pos = backend->next_session_command()->get_position(); @@ -510,6 +512,11 @@ bool RWSplitSession::route_session_write(GWBUF* querybuf, uint8_t command, uint3 m_recv_sescmd++; } } + else + { + MXS_ERROR("Could not route session command: %s", attempted_write ? "Write to all backends failed" : + "All connections have failed"); + } return nsucc; }