From db61ec0d7e828bc0a1c854b09dffdac416b2a357 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=A4kel=C3=A4?= Date: Wed, 15 Nov 2017 13:18:35 +0200 Subject: [PATCH] Add missing initialization in readwritesplit A value was not always initialized for all queries when info level logging was enabled. --- server/modules/routing/readwritesplit/rwsplit_mysql.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/modules/routing/readwritesplit/rwsplit_mysql.cc b/server/modules/routing/readwritesplit/rwsplit_mysql.cc index 824e5a057..8816ca714 100644 --- a/server/modules/routing/readwritesplit/rwsplit_mysql.cc +++ b/server/modules/routing/readwritesplit/rwsplit_mysql.cc @@ -160,8 +160,11 @@ log_transaction_status(RWSplitSession *rses, GWBUF *querybuf, uint32_t qtype) unsigned char command = packet[4]; int len = 0; char* sql; - modutil_extract_SQL(querybuf, &sql, &len); char *qtypestr = qc_typemask_to_string(qtype); + if (!modutil_extract_SQL(querybuf, &sql, &len)) + { + sql = (char*)""; + } if (len > RWSPLIT_TRACE_MSG_LEN) {