hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to http://bugs.skysql.com/show_bug.cgi?id=469, connection counter leaks in master.

Browse Source 
Removed redundant counter increments.
This commit is contained in:
VilhoRaatikka
2014-08-05 16:28:26 +03:00
parent 6b3c7041e3
commit dbfaa5a8ea
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/modules/routing/readwritesplit/readwritesplit.c
View File

@ -381,7 +381,7 @@ static void refreshInstance(
* used in slave selection. * used in slave selection.
*/ */
if (!rlag_enabled) if (!rlag_enabled)
{ {
if (rlag_limited) if (rlag_limited)
{ {
LOGIF(LE, (skygw_log_write_flush( LOGIF(LE, (skygw_log_write_flush(
@ -1985,7 +1985,7 @@ static bool select_connect_backend_servers(
backend_ref[i].bref_state = 0; backend_ref[i].bref_state = 0;
bref_set_state(&backend_ref[i], bref_set_state(&backend_ref[i],
BREF_IN_USE); BREF_IN_USE);
/** /**
* Increase backend connection counter. * Increase backend connection counter.
* Server's stats are _increased_ in * Server's stats are _increased_ in
* dcb.c:dcb_alloc ! * dcb.c:dcb_alloc !
@ -2023,7 +2023,7 @@ static bool select_connect_backend_servers(
session, session,
b->backend_server->protocol); b->backend_server->protocol);
if (backend_ref[i].bref_dcb != NULL) if (backend_ref[i].bref_dcb != NULL)
{ {
master_connected = true; master_connected = true;
/** /**
@ -2040,8 +2040,6 @@ static bool select_connect_backend_servers(
bref_set_state(&backend_ref[i], bref_set_state(&backend_ref[i],
BREF_IN_USE); BREF_IN_USE);
/** Increase backend connection counters */ /** Increase backend connection counters */
atomic_add(&b->backend_server->stats.n_current, 1);
atomic_add(&b->backend_server->stats.n_connections, 1);
atomic_add(&b->backend_conn_count, 1); atomic_add(&b->backend_conn_count, 1);
} }
else else