hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to bug 729: http://bugs.mariadb.com/show_bug.cgi?id=729

Browse Source 
Prepared statements with a SELECT statement were falsely detected as SELECT queries with session variable modification.
This caused the error message and the failure to route the query.
This commit is contained in:
Markus Makela
2015-02-17 18:29:24 +02:00
parent a148861d62
commit dc65c9e1cc
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
server/modules/routing/readwritesplit/readwritesplit.c
View File

@ -1373,8 +1373,19 @@ static route_target_t get_route_target (
* backends but since this is SELECT that is not possible: * backends but since this is SELECT that is not possible:
* 1. response set is not handled correctly in clientReply and * 1. response set is not handled correctly in clientReply and
* 2. multiple results can degrade performance. * 2. multiple results can degrade performance.
*
* Prepared statements are an exception to this since they do not
* actually do anything but only prepare the statement to be used.
* They can be safely routed to all backends since the execution
* is done later.
*
* With prepared statement caching the task of routing
* the execution of the prepared statements to the right server would be
* an easy one. Currently this is not supported.
*/ */
if (QUERY_IS_TYPE(qtype, QUERY_TYPE_READ)) if (QUERY_IS_TYPE(qtype, QUERY_TYPE_READ) &&
!( QUERY_IS_TYPE(qtype, QUERY_TYPE_PREPARE_STMT) ||
QUERY_IS_TYPE(qtype, QUERY_TYPE_PREPARE_NAMED_STMT)))
{ {
LOGIF(LE, (skygw_log_write_flush( LOGIF(LE, (skygw_log_write_flush(
LOGFILE_ERROR, LOGFILE_ERROR,