From dca086571b5d71b1aba891c97fb4fd5945d39f46 Mon Sep 17 00:00:00 2001 From: Esa Korhonen Date: Mon, 3 Apr 2017 13:26:13 +0300 Subject: [PATCH] TestMaxScalePCRE2: Fix memory leaks Not really leaks, but this reduces needless clutter in the valgrind output. --- server/core/test/testmaxscalepcre2.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/core/test/testmaxscalepcre2.c b/server/core/test/testmaxscalepcre2.c index ceb3d142e..5e7ca18b0 100644 --- a/server/core/test/testmaxscalepcre2.c +++ b/server/core/test/testmaxscalepcre2.c @@ -89,11 +89,19 @@ static int test2() test_assert(result == MXS_PCRE2_MATCH, "Substitution should substitute"); test_assert(strcmp(dest, expected) == 0, "Replaced text should match expected text"); + size = 1000; + dest = MXS_REALLOC(dest, size); result = mxs_pcre2_substitute(re2, subject, good_replace, &dest, &size); test_assert(result == MXS_PCRE2_NOMATCH, "Non-matching substitution should not substitute"); + size = 1000; + dest = MXS_REALLOC(dest, size); result = mxs_pcre2_substitute(re, subject, bad_replace, &dest, &size); test_assert(result == MXS_PCRE2_ERROR, "Bad substitution should return an error"); + + MXS_FREE(dest); + pcre2_code_free(re); + pcre2_code_free(re2); return 0; }