hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2556 Check if TCP/IP socket is used and warn about it

Browse Source 
If the server (a real one or a service exposed as a server) is
on the same machine as MaxScale, then for performance reasons
a Unix domain socket and not a TCP/IP socket should be used.
This commit is contained in:
Johan Wikman
2019-06-11 10:48:42 +03:00
parent acdc3b2396
commit df5377f135
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/modules/routing/smartrouter/smartrouter.cc
View File

@ -86,11 +86,29 @@ bool SmartRouter::Config::post_configure(const MXS_CONFIG_PARAMETER& params)
bool rv = true; bool rv = true;
auto servers = params.get_server_list(CN_SERVERS); auto servers = params.get_server_list(CN_SERVERS);
// TODO: Check that the servers are local ones.
auto it = std::find(servers.begin(), servers.end(), m_master.get()); bool master_found = false;
if (it == servers.end()) for (SERVER* pServer : servers)
{
if (pServer == m_master.get())
{
master_found = true;
}
if (pServer->address[0] != '/')
{
if (strcmp(pServer->address, "127.0.0.1") == 0 || strcmp(pServer->address, "localhost"))
{
MXS_WARNING("The server %s, used by the smartrouter, is currently accessed "
"using a TCP/IP socket (%s:%d). For better performance, a Unix "
"domain socket should be used. See the 'socket' argument.",
pServer->name(), pServer->address, pServer->port);
}
}
}
if (rv && !master_found)
{ {
rv = false; rv = false;