From df9f8eba82f08c87b217c6d476ae1e460bcba2fc Mon Sep 17 00:00:00 2001 From: Markus Makela Date: Sat, 9 Apr 2016 23:15:25 +0300 Subject: [PATCH] Improved binlogrouter event distribution error messages Added master position and current safe event to log messages about unexpected slave binlog file positions. --- server/modules/routing/binlog/blr_master.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/server/modules/routing/binlog/blr_master.c b/server/modules/routing/binlog/blr_master.c index 03614a368..d19991cf1 100644 --- a/server/modules/routing/binlog/blr_master.c +++ b/server/modules/routing/binlog/blr_master.c @@ -1972,12 +1972,13 @@ blr_distribute_binlog_record(ROUTER_INSTANCE *router, REP_HEADER *hdr, uint8_t * } else { - /** Slave is using unexpected binlog file */ - MXS_ERROR("Slave %s:%d server ID %d is using an unexpected binlog file '%s' with " - "position %d. Master binlog file is '%s' at pos %lu.", slave->dcb->remote, + /** Slave is lagging behind */ + MXS_ERROR("Slave %s:%d server ID %d is using binlog file '%s' with " + "position %d. Master binlog file is '%s' at position %lu " + "with last safe event at %lu.", slave->dcb->remote, ntohs((slave->dcb->ipv4).sin_port), slave->serverid, slave->binlogfile, slave->binlog_pos, router->binlog_name, - (unsigned long)router->current_pos); + router->current_pos, router->current_safe_event); } spinlock_release(&router->binlog_lock);