Merge branch '2.3' into develop

BUILD/mdbci/copy_repos.sh

@@ -8,7 +8,10 @@ if [ "$box_type" == "RPM" ] ; then
 	# Build can be executed to check if it is possible to build
         # and to run install and upgrade tests
         # with thre real RHEL, but we use CentOS packages for production
-        if [ "$platform" != "rhel" ] ; then
+        if [[ "$platform" != "rhel" || ( "$platform" == "rhel"  && "$platform_version" == "8" ) ]]; then
+                if [[ "$platform" == "rhel"  && "$platform_version" == "8" ]]; then
+                        export platform="centos"
+                fi
                 export arch=`ssh $sshopt "arch"`
                 . ${script_dir}/generate_build_info_path.sh
 

maxscale-system-test/maxadmin_operations.h

@@ -18,8 +18,6 @@
 #include <errno.h>
 #include <getopt.h>
 
-// #include <version.h>
-
 
 /**
  * @brief Connect to the MaxScale server

maxscale-system-test/mxs585.py

@@ -6,7 +6,7 @@
 
 import maxpython
 
-test1 = maxpython.MaxScaleTest("mxs585.py")
+test1 = maxpython.MaxScaleTest("mxs585.py1")
 
 for i in range(0,100):
     if i % 10 == 0:

maxscale-system-test/nodes.cpp

@@ -50,9 +50,7 @@ void Nodes::generate_ssh_cmd(char* cmd, int node, const char* ssh, bool sudo)
         }
         else
         {
-            sprintf(cmd,
-                    "%s",
-                    ssh);
+            sprintf(cmd, "%s", ssh);
         }
     }
     else

maxscale-system-test/testconnections.cpp

@@ -273,10 +273,13 @@ TestConnections::TestConnections(int argc, char* argv[])
         }
     }
 
-    test_name = basename(argv[0]);
-    if (!strcmp(test_name, "non_native_setup"))
+    if (optind < argc)
     {
-        test_name = argv[1];
+        test_name = argv[optind];
+    }
+    else
+    {
+        test_name = basename(argv[0]);
     }
 
     const char * labels_string = NULL;
@@ -424,6 +427,24 @@ TestConnections::TestConnections(int argc, char* argv[])
         }
     }
 
+    if ((maxscale::restart_galera) && (galera))
+    {
+        galera->stop_nodes();
+        galera->start_replication();
+    }
+
+    if (maxscale::check_nodes)
+    {
+        if (repl && !repl->fix_replication())
+        {
+            exit(BROKEN_VM_FAUILT);
+        }
+        if (galera && !galera->fix_replication())
+        {
+            exit(BROKEN_VM_FAUILT);
+        }
+    }
+
     if (repl && maxscale::required_repl_version.length())
     {
         int ver_repl_required = get_int_version(maxscale::required_repl_version);
@@ -454,24 +475,6 @@ TestConnections::TestConnections(int argc, char* argv[])
         }
     }
 
-    if ((maxscale::restart_galera) && (galera))
-    {
-        galera->stop_nodes();
-        galera->start_replication();
-    }
-
-    if (maxscale::check_nodes)
-    {
-        if (repl && !repl->fix_replication())
-        {
-            exit(BROKEN_VM_FAUILT);
-        }
-        if (galera && !galera->fix_replication())
-        {
-            exit(BROKEN_VM_FAUILT);
-        }
-    }
-
     if (maxscale_init)
     {
         init_maxscales();
@@ -616,7 +619,8 @@ void TestConnections::read_mdbci_info()
     target = readenv("target", "develop");
 
     mdbci_config_name = readenv("mdbci_config_name", "local");
-    vm_path = std::string(mdbci_vm_path) + std::string(mdbci_config_name);
+    vm_path = std::string(mdbci_vm_path) + "/" + std::string(mdbci_config_name);
+
     if (mdbci_config_name != NULL)
     {
         std::ifstream nc_file;
@@ -2206,6 +2210,13 @@ int TestConnections::call_mdbci(const char * options)
         tprintf("MDBCI failed to bring up virtual machines");
         return 1;
     }
+
+    std::string team_keys = readenv("team_keys", "~/.ssh/id_rsa.pub");
+    system((std::string("mdbci public_keys --key ") +
+            team_keys +
+            std::string(" ") +
+            std::string(mdbci_config_name)).c_str() );
+
     read_env();
     if (repl)
     {