hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1992 Canonicalize using std::string

Browse Source 
Significantly reducing the number of allocations done.
This commit is contained in:
Johan Wikman 2018-08-01 15:52:34 +03:00
parent bcdab394c1
commit e637acd0a2
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
server/core/query_classifier.cc
View File

@ -20,7 +20,7 @@
#include <maxscale/alloc.h>
#include <maxscale/atomic.h>
#include <maxscale/log_manager.h>
#include <maxscale/modutil.h>
#include <maxscale/modutil.hh>
#include <maxscale/pcre2.h>
#include <maxscale/platform.h>
#include <maxscale/utils.h>
@ -325,20 +325,14 @@ public:
{
if (use_cached_result() && has_not_been_parsed(m_pStmt))
{
char* zCanonical = qc_get_canonical(m_pStmt);
m_canonical = mxs::get_canonical(m_pStmt);
if (zCanonical)
QC_STMT_INFO* pInfo = this_thread.pInfo_cache->get(m_canonical);
if (pInfo)
{
m_canonical = zCanonical;
MXS_FREE(zCanonical);
QC_STMT_INFO* pInfo = this_thread.pInfo_cache->get(m_canonical);
if (pInfo)
{
gwbuf_add_buffer_object(m_pStmt, GWBUF_PARSING_INFO, pInfo, info_object_close);
m_canonical.clear();
}
gwbuf_add_buffer_object(m_pStmt, GWBUF_PARSING_INFO, pInfo, info_object_close);
m_canonical.clear(); // Signals that nothing needs to be added in the destructor.
}
}
}