From eec0b74191ce7b3d15d90de47205dba1afe41077 Mon Sep 17 00:00:00 2001 From: Massimiliano Pinto Date: Fri, 20 Sep 2013 17:53:15 +0200 Subject: [PATCH 1/2] dcb_printf(pdcb, "\tQueued write data: %d\n", gwbuf_length(dcb->writeq)); is now protected by if (dcb->writeq) No more segfaults in dprintAllDCBs --- server/core/dcb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/core/dcb.c b/server/core/dcb.c index 6eeb0b8ff..480fb307d 100644 --- a/server/core/dcb.c +++ b/server/core/dcb.c @@ -896,7 +896,8 @@ DCB *dcb; dcb_printf(pdcb, "\tService: %s\n", dcb->session->service->name); if (dcb->remote) dcb_printf(pdcb, "\tConnected to: %s\n", dcb->remote); - dcb_printf(pdcb, "\tQueued write data: %d\n", gwbuf_length(dcb->writeq)); + if (dcb->writeq) + dcb_printf(pdcb, "\tQueued write data: %d\n", gwbuf_length(dcb->writeq)); dcb_printf(pdcb, "\tStatistics:\n"); dcb_printf(pdcb, "\t\tNo. of Reads: %d\n", dcb->stats.n_reads); dcb_printf(pdcb, "\t\tNo. of Writes: %d\n", dcb->stats.n_writes); From d248ecb180214ff99cc8e908b7a1ecb4d40c5adc Mon Sep 17 00:00:00 2001 From: Massimiliano Pinto Date: Fri, 20 Sep 2013 18:36:31 +0200 Subject: [PATCH 2/2] Added missing parameter in log write, poll_remove_dcb --- server/core/poll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/core/poll.c b/server/core/poll.c index 54308f7df..5fcc88b02 100644 --- a/server/core/poll.c +++ b/server/core/poll.c @@ -207,6 +207,7 @@ poll_remove_dcb(DCB *dcb) "in state %s. Removing from poll set failed.", pthread_self(), STRDCBSTATE(new_state), + dcb, STRDCBSTATE(old_state)); ss_dassert(false); goto return_rc;