hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Invalid invariant in assert caused MaxScale to trap if more bytes were read than the first mysql packet contained according to the mysql packet length field. Since it is typical that session updates and mysql packets come in same transfer this check fails in correct cases as well.

Browse Source 
Removed assertion.
This commit is contained in:
VilhoRaatikka 2014-05-20 22:34:43 +03:00
parent 5c39682e40
commit ebcf4afa52
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/modules/protocol/mysql_client.c
View File

@ -617,8 +617,6 @@ int gw_read_client_event(DCB* dcb) {
}
}
ss_dassert(nbytes_read >= MYSQL_GET_PACKET_LEN((uint8_t *)GWBUF_DATA(read_buffer))+4);
ss_dassert(nbytes_read == MYSQL_GET_PACKET_LEN((uint8_t *)GWBUF_DATA(read_buffer))+4 ||
dcb->dcb_readqueue != NULL);
/**
* Now there should be at least one complete mysql packet in read_buffer.