From ee7e63a6111ec8bf5961c0a0b3349bfc4e958224 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=A4kel=C3=A4?= Date: Wed, 29 May 2019 18:20:45 +0300 Subject: [PATCH] MXS-2464: Assert that responses are expected A query should not be queued if no responses are expected. The code that executes queued queries should be dead code and this assertion would catch it. --- server/modules/routing/readwritesplit/rwsplitsession.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/server/modules/routing/readwritesplit/rwsplitsession.cc b/server/modules/routing/readwritesplit/rwsplitsession.cc index 013bd9489..905952ca4 100644 --- a/server/modules/routing/readwritesplit/rwsplitsession.cc +++ b/server/modules/routing/readwritesplit/rwsplitsession.cc @@ -187,6 +187,7 @@ int32_t RWSplitSession::routeQuery(GWBUF* querybuf) m_query_queue.emplace_back(querybuf); querybuf = NULL; rval = 1; + mxb_assert(m_expected_responses != 0); if (m_expected_responses == 0 && !route_stored_query()) {