hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'develop' into MAX-65

Browse Source
This commit is contained in:
Mark Riddoch
2014-06-04 21:14:31 +01:00
parent 57e910ad3d 7e863657db
commit f612b90cd7
10 changed files with 106 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/MaxScale_template.cnf
View File

@ -20,6 +20,8 @@ threads=1
# user =<user name - must have slave replication and # user =<user name - must have slave replication and
# slave client privileges> # slave client privileges>
# passwd=<password of the above user, plain text currently> # passwd=<password of the above user, plain text currently>
# monitor_interval=<sampling interval in milliseconds,
# default value is 10000>
[MySQL Monitor] [MySQL Monitor]
type=monitor type=monitor

2
server/core/server.c
View File

@ -344,6 +344,8 @@ char *status = NULL;
if ((status = (char *)malloc(200)) == NULL) if ((status = (char *)malloc(200)) == NULL)
return NULL; return NULL;
status[0] = 0; status[0] = 0;
if (server->status & SERVER_MAINT)
strcat(status, "Maintenance, ");
if (server->status & SERVER_MASTER) if (server->status & SERVER_MASTER)
strcat(status, "Master, "); strcat(status, "Master, ");
if (server->status & SERVER_SLAVE) if (server->status & SERVER_SLAVE)

15
server/include/server.h
View File

@ -35,6 +35,7 @@
* 20/05/14 Massimiliano Pinto Addition of server_string field * 20/05/14 Massimiliano Pinto Addition of server_string field
* 20/05/14 Massimiliano Pinto Addition of node_id field * 20/05/14 Massimiliano Pinto Addition of node_id field
* 23/05/14 Massimiliano Pinto Addition of rlag and node_ts fields * 23/05/14 Massimiliano Pinto Addition of rlag and node_ts fields
* 03/06/14 Mark Riddoch Addition of maintainance mode
* *
* @endverbatim * @endverbatim
*/ */
@ -80,12 +81,13 @@ typedef struct server {
#define SERVER_MASTER 0x0002 /**<< The server is a master, i.e. can handle writes */ #define SERVER_MASTER 0x0002 /**<< The server is a master, i.e. can handle writes */
#define SERVER_SLAVE 0x0004 /**<< The server is a slave, i.e. can handle reads */ #define SERVER_SLAVE 0x0004 /**<< The server is a slave, i.e. can handle reads */
#define SERVER_JOINED 0x0008 /**<< The server is joined in a Galera cluster */ #define SERVER_JOINED 0x0008 /**<< The server is joined in a Galera cluster */
#define SERVER_MAINT 0x1000 /**<< Server is in maintenance mode */
/** /**
* Is the server running - the macro returns true if the server is marked as running * Is the server running - the macro returns true if the server is marked as running
* regardless of it's state as a master or slave * regardless of it's state as a master or slave
*/ */
#define SERVER_IS_RUNNING(server) ((server)->status & SERVER_RUNNING) #define SERVER_IS_RUNNING(server) (((server)->status & (SERVER_RUNNING|SERVER_MAINT)) == SERVER_RUNNING)
/** /**
* Is the server marked as down - the macro returns true if the server is beleived * Is the server marked as down - the macro returns true if the server is beleived
* to be inoperable. * to be inoperable.
@ -96,19 +98,24 @@ typedef struct server {
* in order for the macro to return true * in order for the macro to return true
*/ */
#define SERVER_IS_MASTER(server) \ #define SERVER_IS_MASTER(server) \
(((server)->status & (SERVER_RUNNING|SERVER_MASTER|SERVER_SLAVE)) == (SERVER_RUNNING|SERVER_MASTER)) (((server)->status & (SERVER_RUNNING|SERVER_MASTER|SERVER_SLAVE|SERVER_MAINT)) == (SERVER_RUNNING|SERVER_MASTER))
/** /**
* Is the server a slave? The server must be both running and marked as a slave * Is the server a slave? The server must be both running and marked as a slave
* in order for the macro to return true * in order for the macro to return true
*/ */
#define SERVER_IS_SLAVE(server) \ #define SERVER_IS_SLAVE(server) \
(((server)->status & (SERVER_RUNNING|SERVER_MASTER|SERVER_SLAVE)) == (SERVER_RUNNING|SERVER_SLAVE)) (((server)->status & (SERVER_RUNNING|SERVER_MASTER|SERVER_SLAVE|SERVER_MAINT)) == (SERVER_RUNNING|SERVER_SLAVE))
/** /**
* Is the server joined Galera node? The server must be running and joined. * Is the server joined Galera node? The server must be running and joined.
*/ */
#define SERVER_IS_JOINED(server) \ #define SERVER_IS_JOINED(server) \
(((server)->status & (SERVER_RUNNING|SERVER_JOINED)) == (SERVER_RUNNING|SERVER_JOINED)) (((server)->status & (SERVER_RUNNING|SERVER_JOINED|SERVER_MAINT)) == (SERVER_RUNNING|SERVER_JOINED))
/**
* Is the server in maintenance mode.
*/
#define SERVER_IN_MAINT(server) ((server)->status & SERVER_MAINT)
extern SERVER *server_alloc(char *, char *, unsigned short); extern SERVER *server_alloc(char *, char *, unsigned short);
extern int server_free(SERVER *); extern int server_free(SERVER *);

3
server/modules/include/readwritesplit.h
View File

@ -229,7 +229,6 @@ typedef struct router_instance {
} ROUTER_INSTANCE; } ROUTER_INSTANCE;
#define BACKEND_TYPE(b) (SERVER_IS_MASTER((b)->backend_server) ? BE_MASTER : \ #define BACKEND_TYPE(b) (SERVER_IS_MASTER((b)->backend_server) ? BE_MASTER : \
(SERVER_IS_SLAVE((b)->backend_server) ? BE_SLAVE : \ (SERVER_IS_SLAVE((b)->backend_server) ? BE_SLAVE : BE_UNDEFINED));
(SERVER_IS_JOINED((b)->backend_server) ? BE_JOINED : BE_UNDEFINED)));
#endif /*< _RWSPLITROUTER_H */ #endif /*< _RWSPLITROUTER_H */

34
server/modules/monitor/galera_mon.c
View File

@ -28,6 +28,7 @@
* that has the lowest value of wsrep_local_index * that has the lowest value of wsrep_local_index
* 23/05/14 Massimiliano Pinto Added 1 configuration option (setInterval). * 23/05/14 Massimiliano Pinto Added 1 configuration option (setInterval).
* Interval is printed in diagnostics. * Interval is printed in diagnostics.
* 03/06/14 Mark Riddoch Add support for maintenance mode
* *
* @endverbatim * @endverbatim
*/ */
@ -309,13 +310,29 @@ char *server_string;
if (uname == NULL) if (uname == NULL)
return; return;
/* Don't even probe server flagged as in maintenance */
if (SERVER_IN_MAINT(database->server))
return;
if (database->con == NULL || mysql_ping(database->con) != 0) if (database->con == NULL || mysql_ping(database->con) != 0)
{ {
char *dpwd = decryptPassword(passwd); char *dpwd = decryptPassword(passwd);
int rc;
int read_timeout = 1;
database->con = mysql_init(NULL); database->con = mysql_init(NULL);
rc = mysql_options(database->con, MYSQL_OPT_READ_TIMEOUT, (void *)&read_timeout);
if (mysql_real_connect(database->con, database->server->name, if (mysql_real_connect(database->con, database->server->name,
uname, dpwd, NULL, database->server->port, NULL, 0) == NULL) uname, dpwd, NULL, database->server->port, NULL, 0) == NULL)
{ {
LOGIF(LE, (skygw_log_write_flush(
LOGFILE_ERROR,
"Error : Monitor was unable to connect to "
"server %s:%d : \"%s\"",
database->server->name,
database->server->port,
mysql_error(database->con))));
server_clear_status(database->server, SERVER_RUNNING); server_clear_status(database->server, SERVER_RUNNING);
database->server->node_id = -1; database->server->node_id = -1;
free(dpwd); free(dpwd);
@ -411,11 +428,12 @@ long master_id;
while (ptr) while (ptr)
{ {
unsigned int prev_status = ptr->server->status;
monitorDatabase(ptr, handle->defaultUser, handle->defaultPasswd); monitorDatabase(ptr, handle->defaultUser, handle->defaultPasswd);
/* set master_id to the lowest value of ptr->server->node_id */ /* set master_id to the lowest value of ptr->server->node_id */
if (ptr->server->node_id >= 0 && SERVER_IS_JOINED(ptr->server)) { if ((! SERVER_IN_MAINT(ptr->server)) && ptr->server->node_id >= 0 && SERVER_IS_JOINED(ptr->server)) {
if (ptr->server->node_id < master_id && master_id >= 0) { if (ptr->server->node_id < master_id && master_id >= 0) {
master_id = ptr->server->node_id; master_id = ptr->server->node_id;
} else { } else {
@ -423,11 +441,21 @@ long master_id;
master_id = ptr->server->node_id; master_id = ptr->server->node_id;
} }
} }
} else { } else if (!SERVER_IN_MAINT(ptr->server)) {
/* clear M/S status */ /* clear M/S status */
server_clear_status(ptr->server, SERVER_SLAVE); server_clear_status(ptr->server, SERVER_SLAVE);
server_clear_status(ptr->server, SERVER_MASTER); server_clear_status(ptr->server, SERVER_MASTER);
} }
if (ptr->server->status != prev_status ||
SERVER_IS_DOWN(ptr->server))
{
LOGIF(LM, (skygw_log_write_flush(
LOGFILE_MESSAGE,
"Backend server %s:%d state : %s",
ptr->server->name,
ptr->server->port,
STRSRVSTATUS(ptr->server))));
}
ptr = ptr->next; ptr = ptr->next;
} }
@ -436,7 +464,7 @@ long master_id;
/* this server loop sets Master and Slave roles */ /* this server loop sets Master and Slave roles */
while (ptr) while (ptr)
{ {
if (ptr->server->node_id >= 0 && master_id >= 0) { if ((! SERVER_IN_MAINT(ptr->server)) && ptr->server->node_id >= 0 && master_id >= 0) {
/* set the Master role */ /* set the Master role */
if (SERVER_IS_JOINED(ptr->server) && (ptr->server->node_id == master_id)) { if (SERVER_IS_JOINED(ptr->server) && (ptr->server->node_id == master_id)) {
server_set_status(ptr->server, SERVER_MASTER); server_set_status(ptr->server, SERVER_MASTER);

45
server/modules/monitor/mysql_mon.c
View File

@ -32,6 +32,7 @@
* New server field version_string is updated. * New server field version_string is updated.
* 28/05/14 Massimiliano Pinto Added set Id and configuration options (setInverval) * 28/05/14 Massimiliano Pinto Added set Id and configuration options (setInverval)
* Parameters are now printed in diagnostics * Parameters are now printed in diagnostics
* 03/06/14 Mark Ridoch Add support for maintenance mode
* *
* @endverbatim * @endverbatim
*/ */
@ -301,7 +302,7 @@ char *sep;
* Monitor an individual server * Monitor an individual server
* *
* @param handle The MySQL Monitor object * @param handle The MySQL Monitor object
* @param database The database to probe * @param database The database to probe
*/ */
static void static void
monitorDatabase(MYSQL_MONITOR *handle, MONITOR_SERVERS *database) monitorDatabase(MYSQL_MONITOR *handle, MONITOR_SERVERS *database)
@ -323,10 +324,19 @@ int replication_heartbeat = handle->replicationHeartbeat;
} }
if (uname == NULL) if (uname == NULL)
return; return;
/* Don't probe servers in maintenance mode */
if (SERVER_IN_MAINT(database->server))
return;
if (database->con == NULL || mysql_ping(database->con) != 0) if (database->con == NULL || mysql_ping(database->con) != 0)
{ {
char *dpwd = decryptPassword(passwd); char *dpwd = decryptPassword(passwd);
int rc;
int read_timeout = 1;
database->con = mysql_init(NULL); database->con = mysql_init(NULL);
rc = mysql_options(database->con, MYSQL_OPT_READ_TIMEOUT, (void *)&read_timeout);
if (mysql_real_connect(database->con, if (mysql_real_connect(database->con,
database->server->name, database->server->name,
uname, uname,
@ -336,6 +346,14 @@ int replication_heartbeat = handle->replicationHeartbeat;
NULL, NULL,
0) == NULL) 0) == NULL)
{ {
LOGIF(LE, (skygw_log_write_flush(
LOGFILE_ERROR,
"Error : Monitor was unable to connect to "
"server %s:%d : \"%s\"",
database->server->name,
database->server->port,
mysql_error(database->con))));
free(dpwd); free(dpwd);
server_clear_status(database->server, SERVER_RUNNING); server_clear_status(database->server, SERVER_RUNNING);
return; return;
@ -620,7 +638,6 @@ int replication_heartbeat = handle->replicationHeartbeat;
server_clear_status(database->server, SERVER_SLAVE); server_clear_status(database->server, SERVER_SLAVE);
server_clear_status(database->server, SERVER_MASTER); server_clear_status(database->server, SERVER_MASTER);
} }
} }
/** /**
@ -655,13 +672,27 @@ MONITOR_SERVERS *ptr;
ptr = handle->databases; ptr = handle->databases;
while (ptr) while (ptr)
{ {
unsigned int prev_status = ptr->server->status;
monitorDatabase(handle, ptr); monitorDatabase(handle, ptr);
if (ptr->server->status != prev_status ||
SERVER_IS_DOWN(ptr->server))
{
LOGIF(LM, (skygw_log_write_flush(
LOGFILE_MESSAGE,
"Backend server %s:%d state : %s",
ptr->server->name,
ptr->server->port,
STRSRVSTATUS(ptr->server))));
}
ptr = ptr->next; ptr = ptr->next;
} }
thread_millisleep(handle->interval); thread_millisleep(handle->interval);
} }
} }
/** /**
* Set the default id to use in the monitor. * Set the default id to use in the monitor.
* *
@ -670,11 +701,11 @@ MONITOR_SERVERS *ptr;
*/ */
static void static void
defaultId(void *arg, unsigned long id) defaultId(void *arg, unsigned long id)
{ {
MYSQL_MONITOR *handle = (MYSQL_MONITOR *)arg; MYSQL_MONITOR *handle = (MYSQL_MONITOR *)arg;
memcpy(&handle->id, &id, sizeof(unsigned long)); memcpy(&handle->id, &id, sizeof(unsigned long));
} }
/** /**
* Set the monitor sampling interval. * Set the monitor sampling interval.
* *
@ -686,7 +717,7 @@ setInterval(void *arg, unsigned long interval)
{ {
MYSQL_MONITOR *handle = (MYSQL_MONITOR *)arg; MYSQL_MONITOR *handle = (MYSQL_MONITOR *)arg;
memcpy(&handle->interval, &interval, sizeof(unsigned long)); memcpy(&handle->interval, &interval, sizeof(unsigned long));
} }
/** /**
* Enable/Disable the MySQL Replication hearbeat, detecting slave lag behind master. * Enable/Disable the MySQL Replication hearbeat, detecting slave lag behind master.

12
server/modules/routing/debugcmd.c
View File

@ -773,11 +773,13 @@ static struct {
char *str; char *str;
unsigned int bit; unsigned int bit;
} ServerBits[] = { } ServerBits[] = {
{ "running", SERVER_RUNNING }, { "running", SERVER_RUNNING },
{ "master", SERVER_MASTER }, { "master", SERVER_MASTER },
{ "slave", SERVER_SLAVE }, { "slave", SERVER_SLAVE },
{ "synced", SERVER_JOINED }, { "synced", SERVER_JOINED },
{ NULL, 0 } { "maintenance", SERVER_MAINT },
{ "maint", SERVER_MAINT },
{ NULL, 0 }
}; };
/** /**
* Map the server status bit * Map the server status bit

3
server/modules/routing/readconnroute.c
View File

@ -352,6 +352,9 @@ int master_host = -1;
inst->bitmask))); inst->bitmask)));
} }
if (SERVER_IN_MAINT(inst->servers[i]->server))
continue;
/* /*
* If router_options=slave, get the running master * If router_options=slave, get the running master
* It will be used if there are no running slaves at all * It will be used if there are no running slaves at all

11
server/modules/routing/readwritesplit/readwritesplit.c
View File

@ -808,15 +808,14 @@ static bool get_dcb(
} }
ss_dassert(succp); ss_dassert(succp);
} }
else if (btype == BE_MASTER || BE_JOINED) else if (btype == BE_MASTER)
{ {
for (i=0; i<rses->rses_nbackends; i++) for (i=0; i<rses->rses_nbackends; i++)
{ {
BACKEND* b = backend_ref[i].bref_backend; BACKEND* b = backend_ref[i].bref_backend;
if (backend_ref[i].bref_dcb != NULL && if (backend_ref[i].bref_dcb != NULL &&
(SERVER_IS_MASTER(b->backend_server) || (SERVER_IS_MASTER(b->backend_server)))
SERVER_IS_JOINED(b->backend_server)))
{ {
*p_dcb = backend_ref[i].bref_dcb; *p_dcb = backend_ref[i].bref_dcb;
succp = true; succp = true;
@ -1554,8 +1553,7 @@ static bool select_connect_backend_servers(
} }
} }
else if (!master_connected && else if (!master_connected &&
(SERVER_IS_MASTER(b->backend_server) || (SERVER_IS_MASTER(b->backend_server)))
SERVER_IS_JOINED(b->backend_server)))
{ {
master_found = true; master_found = true;
@ -1656,8 +1654,7 @@ static bool select_connect_backend_servers(
"Selected %s in \t%s:%d", "Selected %s in \t%s:%d",
(btype == BE_MASTER ? "master" : (btype == BE_MASTER ? "master" :
(btype == BE_SLAVE ? "slave" : (btype == BE_SLAVE ? "slave" :
(btype == BE_JOINED ? "galera node" : "unknown node type")),
"unknown node type"))),
b->backend_server->name, b->backend_server->name,
b->backend_server->port))); b->backend_server->port)));
} }

8
utils/skygw_debug.h
View File

@ -228,7 +228,13 @@ typedef enum skygw_chk_t {
((c) == LEAST_GLOBAL_CONNECTIONS ? "LEAST_GLOBAL_CONNECTIONS" : \ ((c) == LEAST_GLOBAL_CONNECTIONS ? "LEAST_GLOBAL_CONNECTIONS" : \
((c) == LEAST_ROUTER_CONNECTIONS ? "LEAST_ROUTER_CONNECTIONS" : \ ((c) == LEAST_ROUTER_CONNECTIONS ? "LEAST_ROUTER_CONNECTIONS" : \
((c) == LEAST_BEHIND_MASTER ? "LEAST_BEHIND_MASTER" : "Unknown criteria")))) ((c) == LEAST_BEHIND_MASTER ? "LEAST_BEHIND_MASTER" : "Unknown criteria"))))
#define STRSRVSTATUS(s) ((SERVER_IS_RUNNING(s) && SERVER_IS_MASTER(s)) ? "RUNNING MASTER" : \
((SERVER_IS_RUNNING(s) && SERVER_IS_SLAVE(s)) ? "RUNNING SLAVE" : \
((SERVER_IS_RUNNING(s) && SERVER_IS_JOINED(s)) ? "RUNNING JOINED" : \
((SERVER_IS_RUNNING(s) && SERVER_IN_MAINT(s)) ? "RUNNING MAINTENANCE" : \
(SERVER_IS_RUNNING(s) ? "RUNNING (only)" : "NO STATUS")))))
#define CHK_MLIST(l) { \ #define CHK_MLIST(l) { \
ss_info_dassert((l->mlist_chk_top == CHK_NUM_MLIST && \ ss_info_dassert((l->mlist_chk_top == CHK_NUM_MLIST && \
l->mlist_chk_tail == CHK_NUM_MLIST), \ l->mlist_chk_tail == CHK_NUM_MLIST), \