hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache: It is a hit, also when a stale item is returned

Browse Source 
Also add asserts for impossible cases.
This commit is contained in:
Johan Wikman 2016-12-08 16:38:12 +02:00
parent ebca707335
commit fcd737a0c9
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/modules/filter/cache/lrustorage.cc vendored
View File

@ -72,7 +72,7 @@ cache_result_t LRUStorage::do_get_value(const CACHE_KEY& key,
cache_result_t result = pstorage_->get_value(key, flags, ppvalue); cache_result_t result = pstorage_->get_value(key, flags, ppvalue);
if (result == CACHE_RESULT_OK) if ((result == CACHE_RESULT_OK) || (result == CACHE_RESULT_STALE))
{ {
++stats_.hits; ++stats_.hits;
@ -87,6 +87,7 @@ cache_result_t LRUStorage::do_get_value(const CACHE_KEY& key,
} }
else else
{ {
ss_dassert(!true);
MXS_ERROR("Item found in storage, but not in key mapping."); MXS_ERROR("Item found in storage, but not in key mapping.");
} }
} }
@ -96,6 +97,7 @@ cache_result_t LRUStorage::do_get_value(const CACHE_KEY& key,
if (existed && (result == CACHE_RESULT_NOT_FOUND)) if (existed && (result == CACHE_RESULT_NOT_FOUND))
{ {
ss_dassert(!true);
MXS_ERROR("Item was not found in storage, but was found in key mapping."); MXS_ERROR("Item was not found in storage, but was found in key mapping.");
} }
} }
@ -238,6 +240,7 @@ cache_result_t LRUStorage::do_del_value(const CACHE_KEY& key)
} }
else else
{ {
ss_dassert(!true);
MXS_ERROR("Key was found from storage, but not from LRU register."); MXS_ERROR("Key was found from storage, but not from LRU register.");
} }
} }
@ -325,6 +328,7 @@ bool LRUStorage::free_node_data(Node* pnode)
if (i == nodes_per_key_.end()) if (i == nodes_per_key_.end())
{ {
ss_dassert(!true);
MXS_ERROR("Item in LRU list was not found in key mapping."); MXS_ERROR("Item in LRU list was not found in key mapping.");
} }
@ -333,6 +337,7 @@ bool LRUStorage::free_node_data(Node* pnode)
switch (result) switch (result)
{ {
case CACHE_RESULT_NOT_FOUND: case CACHE_RESULT_NOT_FOUND:
ss_dassert(!true);
MXS_ERROR("Item in LRU list was not found in storage."); MXS_ERROR("Item in LRU list was not found in storage.");
case CACHE_RESULT_OK: case CACHE_RESULT_OK:
if (i != nodes_per_key_.end()) if (i != nodes_per_key_.end())
@ -349,6 +354,7 @@ bool LRUStorage::free_node_data(Node* pnode)
break; break;
default: default:
ss_dassert(!true);
MXS_ERROR("Could not remove value from storage, cannot " MXS_ERROR("Could not remove value from storage, cannot "
"remove from LRU list or key mapping either."); "remove from LRU list or key mapping either.");
success = false; success = false;