Commit Graph

217 Commits

Author SHA1 Message Date
6c6f81abce Fix to MXS-427: https://mariadb.atlassian.net/browse/MXS-427
Stack allocated buffers now have a maximum size.
2015-10-26 10:06:20 +02:00
3751299731 Bool arguments replaced with enum.
Mush easier to see at the call-site what actually is done.
2015-10-22 16:05:23 +03:00
d93d01b116 General tidying
General tidying and correction of missed points during
earlier cleanup steps.
2015-10-22 14:54:03 +03:00
20364a132b Whitespace changes.
All binary operators surrounded by a space.
2015-10-22 14:40:57 +03:00
cb468be04f Function declarations changed to common Maxscale style. 2015-10-22 14:26:41 +03:00
18181e8cb9 All keywords now followed by space.
Plus some missing Allman identation fixes.
2015-10-22 10:58:32 +03:00
ba23fc6fa2 Structures renamed according to style guide.
Structures renamed according to style guide and forward declaration
moved from header (where they are not needed) to implementation.
2015-10-21 14:54:41 +03:00
f47b6324a1 Allman indentation style applied. 2015-10-21 14:54:19 +03:00
76f4f4fe89 Indentation and whitespace fixes.
Straightforward indentation and whitespace modifications.
This is the first one in a series of commits that will bring
log manager in line with the coding style.
2015-10-21 14:53:48 +03:00
338b870cd1 Fix to MXS-373: https://mariadb.atlassian.net/browse/MXS-373
The log manager is initialized only once and skygw_log_sync_all now checks if the log manager has been successfully started before interacting with the log manager
2015-09-21 17:27:49 +03:00
e443351341 Fix to MXS-279: https://mariadb.atlassian.net/browse/MXS-279
Added NULL checks to block buffer initialization and checks for return values to functions that use it.
2015-09-14 16:29:14 +03:00
37f8148574 MXS-362: Enable/disable log augmentation
Log message augmentation (appending of function name) can now
be enabled or disabled via the configuration file and command
line.

By default, the augmentation is disabled.
2015-09-11 15:58:31 +03:00
b84dbd8d3f MXS-357: Possibility to turn off log message augmentation.
It's not always desireable to have the function name
appended to every logged line.
2015-09-09 10:59:22 +03:00
0779673403 MXS-228: Include file name and line numbers
This change does not log the file name and line numbers,
but the function name. Together with the commit information
that is logged in conjunction with a crash and that MaxScale
can tell, when invoked, that is enough to be able to pinpoint
the location where a logging was made. Furthermore, that is
a lot less intrusive and less confusing for an
end-user than filename + line.

This is just a temporary workaround; the logging mechanism
needs to get an overhaul:

- Separate severity and logging target.
- Take syslog severities into use.
- Simplify what needs to be done by developer.
- etc.
2015-09-07 12:32:32 +03:00
8cd3971d45 Fixed segfault in log manager when writing to multiple logfiles at once. 2015-09-07 11:18:43 +03:00
160bbb70ee MXS-251: strerror
Replaces all calls to strerror with calls to strerror_r. The former
is non-thread safe while the latter is.
2015-09-05 15:52:13 +03:00
81506c61eb MXS-343: Minor refactoring of logging.
So that the functionality earlier in skygw_log_write[flush] need
not be duplicated. To be used by new logging functions.
2015-09-03 09:44:56 +03:00
6601dfaaa0 Removed all trailing whitespace. 2015-08-31 13:00:59 +03:00
d9bd22ce90 Added a NULL check to the log manager. 2015-08-26 16:32:17 +03:00
2f9ae48f6a Fixed debug logs not working when logging and flushing. 2015-08-26 12:49:00 +03:00
af703f3ef4 fixed default log directory. 2015-07-16 05:43:25 +03:00
7c8a3e287f Merge branch 'master' into develop 2015-07-16 05:40:20 +03:00
0e5ee7c861 Fixed log manager. 2015-07-16 05:39:31 +03:00
4bb776f4e5 Merge branch 'release-1.2'
Conflicts:
	Documentation/Documentation-Contents.md
2015-07-15 16:34:27 +03:00
ba417ef633 Merge remote-tracking branch 'origin/develop' into MXS-122
Conflicts:
	server/core/dcb.c
2015-07-08 14:54:22 +01:00
b73aedd0ca Fixed debug log not working. 2015-07-08 10:05:15 +03:00
03503a8f9b Fix a number of relatively simple bugs shown by Coverity. 2015-06-26 17:31:58 +01:00
0c98a318dd Try to get atomic.h included correctly for C++ 2015-06-22 12:13:28 +01:00
53812dc5d3 Remove include of atomic.h to bring in line with develop 2015-06-22 10:49:07 +01:00
b880350cf3 Complete merge of latest develop branch 2015-06-22 10:39:13 +01:00
4c38e2224b Merge remote-tracking branch 'origin/develop' into MXS-122
Conflicts:
	server/core/CMakeLists.txt
	server/core/dcb.c
	server/include/dcb.h
	server/include/server.h
	server/modules/protocol/mysql_backend.c
2015-06-19 23:12:54 +01:00
79c20bfae8 Fixed trace and debug logs not being created in shared memory. 2015-06-19 04:45:02 +03:00
492918c72c Use common code for atomic_add(). 2015-05-12 16:50:37 +01:00
56b2d073c3 Merge branch 'develop' into release-1.1.1 2015-05-11 09:05:55 +03:00
bb074d8f94 Removed stdout printing of useless messages from maxkeys and maxpasswd. 2015-05-06 21:00:43 +03:00
dcd0098823 Added stdout as an option for log output with the -l or --log command line option. 2015-05-06 17:33:02 +03:00
abd83ffbfc Merge branch 'develop' into release-1.1.1
Conflicts:
	server/modules/routing/schemarouter/schemarouter.c
2015-05-06 12:24:09 +03:00
7c988c4fd5 Removed stdout specific functions in skygw_utils and moved the logic to log_manager instead. 2015-04-30 04:26:48 +03:00
39b4928f29 Switched back to old log names for 1.1 compability. 2015-04-29 20:47:02 +03:00
47e5b12eb8 Added a function that frees the skygw_file_t memory but doesn't close it. 2015-04-29 18:25:35 +03:00
9ce225c2cb Added log manager initialization flag that prints all logs to stdout. 2015-04-29 11:20:40 +03:00
b3745eba3e Logging to file message update
Logging to file message update
2015-04-23 14:44:56 +02:00
86768966b9 Added support for logging messages to multiple logfiles in a single call. 2015-04-09 20:59:52 +03:00
df70fe8a4e Renamed log files to message,error,trace and debug. 2015-04-09 13:40:02 +03:00
5eb223b92e Changed /dev/shm folder names to maxscale.<pid> instead of only <pid>. 2015-03-24 20:00:45 +02:00
1b91f776a3 Added option to disable logging to MaxScale's log files. 2015-03-09 19:38:37 +02:00
1ff0756044 Added a command line option for syslog logging. 2015-03-05 12:37:39 +02:00
ad49c5f402 Added optional millisecond precision to logfiles and created the changelog document. 2015-02-24 18:10:16 +02:00
4f108af0fb Fixed logs missing a single character when called with skygw_log_write_flush. 2015-02-23 20:26:19 +02:00
3924f70d6b Fixed log manager sometimes not writing the last character in a log message.
This was caused by type conversions from int to size_t and the usage of the MAX macro.
2015-02-20 04:42:02 +02:00